[MOSIP-43100] Updated helm chart for uitestrig to support modulewise …

[abhishek8shankar]

…testrigs

Summary by CodeRabbit

• Chores
  • Removed legacy inline comments and simplified configuration text.
  • Restored and exposed scheduling via values with clearer defaults.
  • Standardized image pull policy default to "Always".
  • Reorganized and enhanced environment variable handling for global and module-specific vars, config maps, and secrets.
  • Fixed spacing/indentation issues across templates for consistent rendering.
  • Consolidated port, volume, and mount formatting for predictable output.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

Updated a Helm cronjob template to reorganize environment variable handling (global and module-level), add envFrom sources for ConfigMaps/Secrets, adjust imagePullPolicy fallback to "Always", fix tplvalues rendering calls, and standardize indentation across ports, volumeMounts, volumes, and template render blocks.

Changes

Cohort / File(s)

Summary

Helm Cronjob Template Restructuring helm/uitestrig/templates/cronjob.yaml

Removed legacy comments; set imagePullPolicy to default to "Always" when unspecified; restored schedule exposure via values; consolidated backoffLimit and history limits; refactored command/args rendering for correct spacing; reorganized env entries (including container_user, JDK_JAVA_OPTIONS, modules); added global and module-level extraEnvVars rendering; expanded envFrom to include global/module ConfigMaps and Secrets; standardized indentation and nindent usage across ports, volumeMounts, volumes, and tpl rendering calls.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

• Review tplvalues.render call-site changes for correct context and spacing in command/args and lifecycle hooks.
• Verify imagePullPolicy fallback semantics are intended and tested.
• Validate envFrom ordering and references (global vs module) to avoid precedence issues.
• Confirm all nindent/indentation changes render valid YAML for all conditional branches (ports, volume mounts, configMaps loops).
• Check module-level extraEnvVars and secret/configmap name references for correct templating and escaping.

Poem

🐰
I hopped through lines of YAML bright,
Tidied envs and fixed the sight,
Modules now join the garden fair,
ConfigMaps, Secrets—everywhere!
A cronjob hums, all neat and light.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately reflects the main change: updating the Helm chart for uitestrig to support module-wise testrigs, which aligns with the raw summary describing environment variables, ConfigMaps, and module-specific configurations.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fe62f57 and 2bf84f8.

📒 Files selected for processing (1)

• helm/uitestrig/templates/cronjob.yaml (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Analyze (java-kotlin)

🔇 Additional comments (5)

helm/uitestrig/templates/cronjob.yaml (5)

34-34: Template function name typos have been successfully corrected.

All instances of common.tpvalues.render have been properly updated to common.tplvalues.render across lifecycle, command, args, and both global/module-level extraEnvVars rendering calls. Consistent application throughout the template.

Also applies to: 40-40, 43-43, 55-55, 59-59

---

32-32: imagePullPolicy default is appropriate for CronJobs.

The fallback to "Always" ensures fresh image pulls on each scheduled execution, preventing stale container images. This is a sensible default for functional testing CronJobs.

---

46-60: Environment variable reorganization improves modularity and clarity.

Fixed environment variables (container_user, JDK_JAVA_OPTIONS, modules) are now explicit, with global and module-level extraEnvVars cleanly separated. Consistent indentation (nindent 14) maintains proper YAML structure. This supports the module-wise testrig design well.

---

62-104: envFrom section provides comprehensive modular environment configuration.

The four-subsection structure (global ConfigMaps/Secrets + module-specific ConfigMaps/Secrets) is well-organized and addresses the module-wise testrig requirement. Clear section comments aid maintainability. YAML structure is correct with proper nesting of name fields under configMapRef/secretRef. This design allows flexible environment configuration at both global and per-module levels.

---

19-20: Indentation and formatting standardization is consistent throughout.

The removal of inline comments from history/backoff limits and standardization of indentation across ports, volumeMounts, and volumes sections maintains clean YAML structure. No inconsistencies detected; all blocks properly aligned for Kubernetes manifests.

Also applies to: 24-24, 107-108, 112-114, 117-119, 129-134

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 3

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9021db2 and fe62f57.

📒 Files selected for processing (1)

• helm/uitestrig/templates/cronjob.yaml (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)

• GitHub Check: build-maven-authentication-demo-service / maven-build
• GitHub Check: build-maven-apitest-commons / maven-build
• GitHub Check: chart-lint-publish / chart-lint-publish
• GitHub Check: Analyze (java-kotlin)

🔇 Additional comments (3)

helm/uitestrig/templates/cronjob.yaml (3)

32-32: Good use of fallback for imagePullPolicy.

The default "Always" fallback ensures a sensible default when module-specific pullPolicy is not defined, maintaining compatibility across module configurations.

---

46-60: Module-wise environment variable support is well structured.

The explicit entries for container_user, JDK_JAVA_OPTIONS, and modules, combined with separate rendering of global and module-level extraEnvVars, provides clear separation of concerns and enables module-specific customization.

---

62-105: Comprehensive envFrom block design supports modular configuration.

The new envFrom section effectively consolidates ConfigMaps and Secrets across both global and module-wise scopes, with clear sectioning comments. This structure aligns well with the modulewise testrig support objective and allows independent module configuration without duplicating global settings.

[Mohanraj209]

Approved..