Skip to content

MOSIP-41819 - fix Prereg_GetAppointmentDetails_empty_space_preRegistrationId #1059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ckm007 merged 1 commit into from
Nov 13, 2025
Merged

MOSIP-41819 - fix Prereg_GetAppointmentDetails_empty_space_preRegistrationId #1059

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions ...ooking-service/src/main/java/io/mosip/preregistration/booking/service/BookingService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
import java.util.TreeMap;
import java.util.stream.Collectors;

import io.mosip.kernel.core.idvalidator.exception.InvalidIDException;
import jakarta.annotation.PostConstruct;

import org.apache.commons.lang3.exception.ExceptionUtils;
Expand Down Expand Up @@ -535,6 +536,7 @@ public MainResponseDTO<BookingRegistrationDTO> getAppointmentDetails(String preR
responseDto.setVersion(versionUrl);
RegistrationBookingEntity entity = null;
try {
this.applicationIdValidation(preRegID);
// This call will check if the PRID belongs to the logged in user or not
serviceUtil.checkApplicationStatus(preRegID);
entity = bookingDAO.findByPreRegistrationId(preRegID);
Expand All @@ -558,6 +560,15 @@ public MainResponseDTO<BookingRegistrationDTO> getAppointmentDetails(String preR
return responseDto;
}

private void applicationIdValidation(String applicationId) {
if (applicationId == null || applicationId.trim().isEmpty()) {
throw new InvalidIDException(
ErrorCodes.PRG_BOOK_RCI_022.getCode(),
"preRegistrationId cannot be empty."
);
}
}

/*
* (non-Javadoc)
*
Expand Down
Loading