Skip to content

Fixes: When calculating averages, mosquito can overflow when the sum of 100 values is > int32max. #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robacarp merged 1 commit into from
Apr 11, 2026
Merged

Fixes: When calculating averages, mosquito can overflow when the sum of 100 values is > int32max. #208

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/mosquito/redis_backend.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,8 @@ module Mosquito
def average(key : String) : Int32
stats = redis.lrange key, 0, -1
return 0_i32 if stats.empty?
stats.map(&.as(String).to_i32).sum // stats.size
sum = stats.sum(0_i64) { |s| s.as(String).to_i64 }
(sum // stats.size).to_i32
end

class Queue < Backend::Queue
Expand Down
Loading