trying to fix loadUi widget placement issue#324
Open
MagicRedDeer wants to merge 3 commits intomottosso:masterfrom
Open
trying to fix loadUi widget placement issue#324MagicRedDeer wants to merge 3 commits intomottosso:masterfrom
MagicRedDeer wants to merge 3 commits intomottosso:masterfrom
Conversation
|
|
Owner
|
Thanks for this. Could you implement a test for this as well? That way it'll get run during CI and ensure it works for all bindings on all platforms. Also if you could post a reproducible we could run locally as well, to confirm it works visually that would be great. |
Owner
|
Hi @MagicRedDeer, thanks again for submitting this PR. I know writing tests are a drag, but if you could paste something even in a comment, then we could run it on our end and confirm it works and doesn't break anything else. That would help this PR getting merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an attempt to fix #323. Where a UI loaded in
PySidefrom a.uifile does not show up at the top of the parent widget as expected.This solution creates a new widget as a child or the "base instance" and then uses the new widgets layout or central widget on the base instance.