Skip to content

Optional allow_reassociation flag and ec2 api response for assign ip address call#133

Merged
anosulchik merged 4 commits intomasterfrom
artemnosulchyk/sc-177454/sorcerer-eip-assignment-race-condition
Nov 12, 2025
Merged

Optional allow_reassociation flag and ec2 api response for assign ip address call#133
anosulchik merged 4 commits intomasterfrom
artemnosulchyk/sc-177454/sorcerer-eip-assignment-race-condition

Conversation

@anosulchik
Copy link
Copy Markdown
Contributor

@anosulchik anosulchik commented Nov 11, 2025

Why do we need this change?

  1. Optional allow_reassociation flag for associate EIP EC2 API call
  2. Response from EC2 API is returned in assign_ip_address_with_retries so we can run some validations

Implementation Details

Dependencies (if any)

📇 [sc-177454]

@anosulchik anosulchik requested a review from a team November 11, 2025 21:06
Comment thread lib/movable_ink/aws/ec2.rb Outdated
]
begin
run_with_backoff(expected_errors: expected_errors) do
response = ec2.describe_addresses({
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this use ec2_with_retries, so that it automatically retries getting the credentials?

@anosulchik anosulchik changed the title Optional allow_reassignment flag and ec2 api response for assign ip address call Optional allow_reassociation flag and ec2 api response for assign ip address call Nov 12, 2025
@anosulchik anosulchik merged commit 8088b43 into master Nov 12, 2025
14 checks passed
@anosulchik anosulchik deleted the artemnosulchyk/sc-177454/sorcerer-eip-assignment-race-condition branch November 12, 2025 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants