fix: update excluded page action icon based on theme - #281
Open
Punith1117 wants to merge 1 commit into
Open
Punith1117 wants to merge 1 commit into
Punith1117 wants to merge 1 commit into
Conversation
The excluded page action icon used a static dark asset, which made it difficult to see in Firefox dark mode. This change updates the excluded icon path dynamically based on the active browser color scheme so the icon remains visible in both light and dark themes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The excluded page action icon used a static dark asset, which made it difficult to see in Firefox dark mode.
This change updates the excluded icon path dynamically based on the active browser color scheme so the icon remains visible in both light and dark themes.
For testing, I temporarily forced the excluded page action state locally and verified the icon behavior in:
I initially considered updating the excluded SVG asset directly, but that caused inverse visibility issue in light themes. I noticed the excluded
pageActionicon did not automatically adapt to theme changes when using an explicitsetIcon()path, so the excluded icon selection is now handled explicitly here.Fixes: mozilla-mobile/mozilla-vpn-client#11312