Skip to content

Remove Heroku-specific code and references - #4485

Merged
mathjazz merged 4 commits into
mozilla:mainfrom
mathjazz:3843-remove-heroku-specific-code
Sep 3, 2026
Merged

Remove Heroku-specific code and references#4485
mathjazz merged 4 commits into
mozilla:mainfrom
mathjazz:3843-remove-heroku-specific-code

Conversation

@mathjazz

@mathjazz mathjazz commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator

Fix #3843.

@mathjazz
mathjazz requested a review from flodolo September 3, 2026 10:12

@flodolo flodolo left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confess I'm not a fan of leaving so much code specific for Heroku around.

Can we have a lower priority issue with the list of things that are only needed by Heroku, and get rid of them at some point.

Comment thread README.md Outdated
Comment thread README.md Outdated
Co-authored-by: Francesco Lodolo <flod@lodolo.net>
@flodolo

flodolo commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator

As for the PR title, this is not removing Heroku code, it's only removing some references as a supported platform.

According to the issue, we should also remove https://github.com/mozilla/pontoon/blob/main/package.json#L22?

@mathjazz

mathjazz commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator Author

I confess I'm not a fan of leaving so much code specific for Heroku around.

We could get rid of these:
https://github.com/mozilla/pontoon/blob/main/app.json
https://github.com/mozilla/pontoon/blob/main/pontoon/base/management/commands/heroku_deploy_setup.py

The rest (it's really just 2 files in pontoon/bin and a line in package.json at that point) I'd keep, because we most likely have deployments that rely on them.

@mathjazz

mathjazz commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator Author

According to the issue, we should also remove https://github.com/mozilla/pontoon/blob/main/package.json#L22?

Nah, that one should remain, otherwise npm run build:prod will run twice on Heroku deployments.

@mathjazz

mathjazz commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator Author

As for the PR title, this is not removing Heroku code, it's only removing some references as a supported platform.

It's removing Heroku-specific code from the settings file.

@mathjazz
mathjazz merged commit c0dce2d into mozilla:main Sep 3, 2026
10 checks passed
@mathjazz
mathjazz deleted the 3843-remove-heroku-specific-code branch September 3, 2026 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Modify and remove Heroku-specific code and documentation

2 participants