Keep repo file operations inside the checkout - #4487
Merged
Conversation
A repository can commit a symlink pointing anywhere on the filesystem. Sync followed those links, so a repo could make sync read a file from outside the checkout into the database, or write a translation over one.
eemeli
requested changes
Sep 3, 2026
Co-authored-by: Eemeli Aro <eemeli@gmail.com>
eemeli
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A repository can commit a symlink pointing anywhere on the filesystem. Sync followed those links, so a repo could make sync read a file from outside the checkout into the database, or write a translation over one.
As of this patch, paths are only acted on if inside the checkout.