Don't reject strings with partial files in Upload translations - #4491
Open
flodolo wants to merge 1 commit into
Open
Don't reject strings with partial files in Upload translations#4491flodolo wants to merge 1 commit into
flodolo wants to merge 1 commit into
Conversation
Also, fix a bug in the current implementation leading to approved existing suggestions not being synced to the repo. This is using the existing infobar implementation, but adding a parameter to show it for longer than 2s.
flodolo
force-pushed
the
issue4481_revise_upload_behavior
branch
from
September 3, 2026 16:23
13242eb to
e96c14a
Compare
Collaborator
Author
|
(forced push to pick up the last commit on main, since tests were still running) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also fixes a bug in the current implementation leading to approved existing suggestions not being synced to the repo, because of
write_db_updates()mutating the list passed as argument (hence the explicit test).This is using the existing infobar implementation, but adding a parameter to show it for longer than 2s.
Fixes #4481