Skip to content

options: reset some options between files by default #14151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
guidocella wants to merge 1 commit into
base: master
Choose a base branch
from
Open

options: reset some options between files by default #14151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions DOCS/man/options.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -816,12 +816,12 @@ Program Behavior
defined profiles.

``--reset-on-next-file=<all|option1,option2,...>``
Normally, mpv will try to keep all settings when playing the next file on
Normally, mpv will try to keep most settings when playing the next file on
the playlist, even if they were changed by the user during playback. (This
behavior is the opposite of MPlayer's, which tries to reset all settings
when starting next file.)

Default: Do not reset anything.
Default: ``ab-loop-a``, ``ab-loop-b``, ``ab-loop-count``.

This can be changed with this option. It accepts a list of options, and
mpv will reset the value of these options on playback start to the initial
Expand Down
8 changes: 8 additions & 0 deletions options/options.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -949,6 +949,14 @@ static const m_option_t mp_opts[] = {
static const struct MPOpts mp_default_opts = {
.use_terminal = true,
.msg_color = true,

.reset_options = (char *[]){
"ab-loop-a",
"ab-loop-b",
"ab-loop-count",
Comment on lines +954 to +956

@kasper93 kasper93 May 21, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's so special about ab-loop? As opposed to dozen other properties that shouldn't be preserved between files? Do you plan to list them all here?

Also user can use file-local-options probably too.

@guidocella guidocella May 21, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That it makes no sense to preserve loop points because after changing file they will refer to completely different scenes.

@kasper93 kasper93 May 21, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as dozen different options, that are file specific.

@guidocella guidocella May 21, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see how any other option is as file specific.

@kasper93 kasper93 May 21, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really?

@guidocella guidocella May 21, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.

@na-na-hi na-na-hi May 21, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.

All options in default --watch-later-options are pretty file specific. There is nothing that makes ab loop option different from others.

@guidocella guidocella May 21, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I definitely wanted to preserve the options in --watch-later-options for different files except pan and crop, which autocrop.lua already sets locally. Never for ab loops.

NULL
},

.softvol_max = 130,
.softvol_volume = 100,
.softvol_gain_max = 12,
Expand Down
Loading