Skip to content

video/out/d3d11: add d3d11 composition mode support - #16285

Merged
kasper93 merged 1 commit into
mpv-player:masterfrom
saltpi:master
Jul 6, 2025
Merged

video/out/d3d11: add d3d11 composition mode support#16285
kasper93 merged 1 commit into
mpv-player:masterfrom
saltpi:master

Conversation

@saltpi

@saltpi saltpi commented Apr 26, 2025

Copy link
Copy Markdown
Contributor

Add option to export d3d11 swapchain

@saltpi saltpi changed the title add d3d11 composition mode support vo/d3d11: add d3d11 composition mode support Apr 26, 2025
@saltpi saltpi changed the title vo/d3d11: add d3d11 composition mode support video/out/d3d11: add d3d11 composition mode support Apr 26, 2025
@github-actions

github-actions Bot commented Apr 26, 2025

Copy link
Copy Markdown

@kasper93 kasper93 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not much opinion about it. It looks plumb as is, but if it works it works, I guess. I don't have target to test this, but changes are not that intrusive, so we can have it.

Comment thread video/out/d3d11/context.c Outdated
Comment thread video/out/d3d11/context.c Outdated
Comment thread DOCS/man/options.rst
@saltpi

saltpi commented Apr 28, 2025

Copy link
Copy Markdown
Contributor Author

Hello @kasper93 , all the issue mentioned has been resolved. It would be great if it could be reviewed and merged soon. Thanks!

@saltpi
saltpi requested a review from kasper93 May 29, 2025 15:00

@kasper93 kasper93 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, not tested, but should be fine.

Comment thread DOCS/interface-changes.rst Outdated
Comment thread video/out/d3d11/context.c Outdated
Comment thread DOCS/man/options.rst Outdated
Comment thread DOCS/man/input.rst Outdated
Comment thread player/command.c Outdated
@saltpi
saltpi requested a review from na-na-hi July 6, 2025 04:28
@kasper93
kasper93 merged commit 7df0912 into mpv-player:master Jul 6, 2025
29 checks passed
@FrayxRulez

Copy link
Copy Markdown

I was wondering how to report the actual swap chain panel width and height?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants