vo/vulkan: sync requested extensions and features from ffmpeg - #16657
vo/vulkan: sync requested extensions and features from ffmpeg#16657philipl wants to merge 0 commit into
Conversation
98b6339 to
4aa360e
Compare
|
Download the artifacts for this pull request: Windows |
Remember that since those are optional extensions, they might not exists, and validation errors or the implementation should work fine both with them not loaded. |
For sure. But I mean when doing a side-by-side comparison between |
4aa360e to
09e660e
Compare
09e660e to
5190061
Compare
|
For the record about Vulkan headers version supported. Current Android NDK (r28c) have So, if we ignore oldstable, we could bump requirement to 275, but this covers only 2/7 of those extensions. Probably not worth it. Of course those are only headers, but we aimed to not require side loading them, at least for latest Debian and NDK, which are generally what's lagging behind. Unless there is a need to do so. |
5190061 to
766cf74
Compare
Still seems worth bumping as a matter of principle. If we let debian oldstable hold us back, we'll be here forever. There's a bunch of other clean up we can do now that trixie is out, right? |
766cf74 to
09c3062
Compare
kasper93
left a comment
There was a problem hiding this comment.
LGTM. I didn't check exact versions, but I trust you on that.
sfan5
left a comment
There was a problem hiding this comment.
Can't test but it compiles fine for Android.
|
I'm going to take another pass at this later this week to add all the extensions/features I initial proposed to add directly into libplacebo. Based on the discussion around that, they should all be here too. |
09c3062 to
311aa7a
Compare
|
I have updated to add the additional extensions/features that I had previously added directly in libplacebo. As discussed, I'm putting all of them here so that no libplacebo changes are made. |
311aa7a to
12a7825
Compare
Over time, the list of requested extensions and features has diverged from
ffmpeg (libhwcontext_vulkan), and while this isn't guaranteed to cause
problems, as it depends on driver behaviour, it definitely makes it hard to
compare validation errors between the two implementations.
There is a large list of feature activations that have to be handled by an
update to libplacebo, which I'm making separately.