osxbundle: add new macOS 26 compatible App icon - #17131
Merged
Merged
Conversation
generated with the Icon Composer project: actool ./icon.icon \ --compile ./ \ --app-icon icon \ --enable-on-demand-resources NO \ --development-region en \ --target-device mac \ --platform macosx \ --include-all-app-icons \ --minimum-deployment-target 10.15 \ --output-partial-info-plist /dev/null \ --standalone-icon-behavior all actool will generate an Assets.car file which is compatible with all the new Theme variants of macOS 26 (default, dark, monochrome, tinted, etc). it also generates an old icns file as a fallback, only default style. since the new Assets.car file can't be used from cocoa directly, without using private APIs, we still use the icns file when used from CLI. this also means that from CLI only the default icon is used and the macOS theming doesn't have any effect. the macOS theming mechanism only works with the bundle and a Assets.car file. all icons are generated on the fly depending on the Theme. this generation has no public API and the mechanism would need to be replicated by hand. to replicate this behaviour at least three different icns would need to be generated, tinting needs to be implemented, several system events need to be subscribed, and this wouldn't guarantee the same look as the system mechanism. also none of the tools make it possible to generate macOS 26 compatible icns file, besides for the default file, since it at least is missing the necessary padding.
Member
Author
|
added the Icon Composer file to mpv-player/random-stuff#6 so we don't lose the actual source. |
|
Download the artifacts for this pull request: Windows |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
alternative to #16926. generated with mpv-player/random-stuff#6
this is a lazy macOS 26 compatible icon. it just uses our current icon at 1024x1024px for an Icon Composer project. it tries to preserve the current colour scheme, see remark on the PR mentioned above. it also deactivates all the liquid glass effects, because they don't work well with raster images. for a proper macOS 26 icon we need a properly layered (layered in Icon Composer) vector image(s).
the macOS theming only works with the bundle but not from the CLI. see remarks on the first commit.
just some generation infos:
default, dark, clear light, clear dark, tinted light, tinted dark: