sub: add sub-lines property - #17730
Merged
Merged
Conversation
afishhh
suggested changes
Apr 16, 2026
afishhh
reviewed
Apr 16, 2026
Contributor
|
The API used in the |
Contributor
Author
|
Removed. |
guidocella
force-pushed
the
sub-lines
branch
2 times, most recently
from
April 18, 2026 16:13
bd8f1bb to
2089586
Compare
afishhh
reviewed
Apr 18, 2026
kasper93
reviewed
Apr 20, 2026
kasper93
reviewed
Apr 20, 2026
Return all subtitle lines in memory with text, start and end. I did not name this sub-all so it cannot be misinterpreted as referring to all subtitle tracks. Closes mpv-player#12810.
This: - Removes the dependency of ffmpeg in PATH - useful on Windows, macOS (?), Flatpak. - Will support subrandr. - Avoids redownloading network subtitles. - Avoids slow demuxing of large mkvs. - But no longer returns future lines of embedded subtitles. - No longer returns embedded lines of regions you seeked beyond without playing them. - Changing sub track drops cached subtitles.
kasper93
approved these changes
Apr 25, 2026
kasper93
left a comment
kasper93
left a comment
Member
There was a problem hiding this comment.
I'm fine with this if it works.
Contributor
|
Since |
kasper93
pushed a commit
that referenced
this pull request
Apr 26, 2026
verygoodlee
reviewed
May 6, 2026
| } | ||
|
|
||
| static void dedup_sub_lines(struct sub_lines *lines) | ||
| { |
Contributor
There was a problem hiding this comment.
Is this really necessary?
Even if the same text has overlapping time windows, they may be located at different positions. In such cases, they should not be counted as the same line.
ASS file content
[Script Info]
ScriptType: v4.00+
PlayResX: 1920
PlayResY: 1080
Aspect Ratio: 1920:1080
Collisions: Normal
WrapStyle: 2
ScaledBorderAndShadow: yes
YCbCr Matrix: TV.601
[V4+ Styles]
Format: Name, Fontname, Fontsize, PrimaryColour, SecondaryColour, OutlineColour, BackColour, Bold, Italic, Underline, StrikeOut, ScaleX, ScaleY, Spacing, Angle, BorderStyle, Outline, Shadow, Alignment, MarginL, MarginR, MarginV, Encoding
Style: Foo, sans-serif, 45, &H73FFFFFF, &H73FFFFFF, &H73000000, &H73000000, 0, 0, 0, 0, 100, 100, 0.00, 0.00, 1, 2, 0, 7, 0, 0, 0, 0
[Events]
Dialogue: 2,0:00:00.00,0:00:10.00,Foo,,0000,0000,0000,,{\move(1920, 0, -45, 0)}W
Dialogue: 2,0:00:05.00,0:00:15.00,Foo,,0000,0000,0000,,{\move(1920, 45, -45, 45)}W
Contributor
Author
There was a problem hiding this comment.
Yeah or you end up like #15936 (comment)
Member
There was a problem hiding this comment.
Displaying ASS without styles in a list is broken by design. You want to select subtitle, but at the same time you remove subtitles from the list.
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sub: add sub-lines property
Return all subtitle lines in memory with text, start and end.
I did not name this sub-all so it cannot be misinterpreted as referring to all subtitle tracks.
Closes #12810.
Mostly generated by Claude.
select.lua: use sub-lines instead of forking to ffmpeg
This:
(but holding the up key works)this depends if you enable the cache.