osc: reevaluate mouse state after leaving never - #17969
Merged
Merged
Conversation
currently mouse processing only happens on mouse movement which causes cases where going from never -> auto does not show the osc even though the cursor might be in proximity. move mouse processing code to a function and refresh it when leaving visibility never to avoid such issues. Fixes: mpv-player#17954 (comment)
N-R-K
force-pushed
the
nrk/osc-mouse-reeval
branch
from
May 23, 2026 08:15
858e554 to
a8c9493
Compare
kasper93
reviewed
Jun 3, 2026
| -- mode can be auto/always/never/cycle | ||
| -- the modes only affect internal variables and not stored on its own. | ||
| local function visibility_mode(mode, no_osd) | ||
| local old_vis = mp.get_property_native("user-data/osc/visibility") or user_opts.visibility |
Member
There was a problem hiding this comment.
This is very strange to check user-data here.
Contributor
Author
There was a problem hiding this comment.
If script-opts is updated at runtime then user_opts.visibility contains the new/desired visibility. We want to know the the old visibility that we're transitioning out of.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
currently mouse processing only happens on mouse movement which causes cases where going from never -> auto does not show the osc even though the cursor might be in proximity.
move mouse processing code to a function and refresh it when leaving visibility never to avoid such issues.
Fixes: #17954 (comment)