vo_libmpv: use the VO_CAP of the renderer backend instead of the VO - #18215
Merged
Conversation
The software renderer backend is not capable of using any of the VO capabilities set globally by vo_libmpv. This can lead to assertion errors when trying to render a video with 90 degree rotation metadata. Instead use the ctx->renderer->driver_caps value so the source frame doesn't have its params rotated when it's not desired.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The software renderer backend is not capable of using any of the VO capabilities set globally by vo_libmpv. This can lead to assertion errors when trying to render a video with 90 degree rotation metadata. Instead use the ctx->renderer->driver_caps value so the source frame doesn't have its params rotated when it's not desired.