Skip to content

filter_kernels: add Magic Kernel Sharp 2013 and 2021 scalers - #18290

Open
kasper93 wants to merge 1 commit into
mpv-player:masterfrom
kasper93:add-mks
Open

filter_kernels: add Magic Kernel Sharp 2013 and 2021 scalers#18290
kasper93 wants to merge 1 commit into
mpv-player:masterfrom
kasper93:add-mks

Conversation

@kasper93

Copy link
Copy Markdown
Member

The quadratic B-spline ("magic kernel") convolved with the respective discrete sharpening kernels, expressed as single continuous kernels with a support of radius 2.5 (mks2013) and 4.5 (mks2021).

See https://johncostella.com/magic/ for details.

@llyyr

llyyr commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

The quadratic B-spline ("meme kernel")

The quadratic B-spline ("magic kernel") convolved with the respective
discrete sharpening kernels, expressed as single continuous kernels
with a support of radius 2.5 (mks2013) and 4.5 (mks2021).

See https://johncostella.com/magic/ for details.
Comment thread DOCS/man/options.rst
``mks2021``
Magic Kernel Sharp 2021. A refinement of ``mks2013`` with a flatter
frequency response (support of radius 4.5), making it closer to true
interpolation, at a slightly higher cost and with marginally more

@arch1t3cht arch1t3cht Jul 25, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

true interpolation is confusing language IMO, since it can be understood to imply that there is some objectively correct sort of interpolation. If this is about the kernel being (close to) interpolatory, i.e. a resample to the same res being the identity, then interpolatory might be the better wording.

@kkanungo17

Copy link
Copy Markdown

@llyyr why is it a meme kernel?

@llyyr

llyyr commented Jul 26, 2026

Copy link
Copy Markdown
Contributor

why is it a meme kernel?

See #18288 (comment)

@Jules-A

Jules-A commented Jul 26, 2026

Copy link
Copy Markdown

why is it a meme kernel?

See #18288 (comment)

Based on those results, I wouldn't say it's completely useless, well the 2013 version anyway. It is a lot sharper than the non-EWA filters so can possibly be useful for some people who don't have the hardware for EWA variants and are able to deal with that extreme amount of aliasing (maybe not as big of an issue at higher resolutions? idk). The 2021 variant I can't see a reason to implement though...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants