options: add --playlist-inherit-options=auto and make it default - #18319
options: add --playlist-inherit-options=auto and make it default#18319na-na-hi wants to merge 1 commit into
Conversation
Should make more sense as a default to inherit file local options for ordinary playlists. Items from auto created playlists do not logically belong to the starting item so they are excluded.
| M_RANGE(0, INT_MAX)}, | ||
| {"playlist-inherit-options", OPT_CHOICE(playlist_inherit_options, | ||
| {"no", 0}, {"yes", 1}, {"current", 2})}, | ||
| {"no", 0}, {"yes", 1}, {"current", 2}, {"auto", 3})}, |
There was a problem hiding this comment.
auto should be 0 by convention, default options are 0 if possible.
There was a problem hiding this comment.
auto should be 0 by convention
Is it?
Out of 85 "auto" values, 15 are 0.
Out of 70 "no" values, 40 are 0.
Clearly by convention no should be 0, not auto.
There was a problem hiding this comment.
Default values are 0 because it avoids explicit initializer and is consistent with any structure initialization.
There was a problem hiding this comment.
Default values are 0 because it avoids explicit initializer and is consistent with any structure initialization.
Yes, but this is not a convention.
--gapless-audio: no - 0, yes - 1, default - -1
--stop-screensaver: no - 0, yes - 1, default - 1
--term-osd: no - 0, auto - 2, default - 2
and so on...
2 participants
Should make more sense as a default to inherit file local options for ordinary playlists. Items from auto created playlists do not logically belong to the starting item so they are excluded.