fix: Handle bound method calls in defer statements#22
Merged
Conversation
Previously, `checkDeferredCall` did not handle bound method calls
(method values), causing false negatives when a bound method was
deferred.
Example that was previously missed:
e := logger.Info()
msg := e.Msg
defer msg("deferred") // Now correctly reports missing ctx
Added `checkDeferredBoundMethodTerminator` which mirrors the logic
of `checkBoundMethodTerminator` for defer statements.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #22 +/- ##
==========================================
- Coverage 89.31% 88.79% -0.52%
==========================================
Files 7 7
Lines 468 482 +14
==========================================
+ Hits 418 428 +10
- Misses 29 31 +2
- Partials 21 23 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
checkDeferredCallcheckDeferredBoundMethodTerminatorfunctionFixes #21
Test plan
./test_all.shpasses🤖 Generated with Claude Code