Replace "delete" with "heap_caps_free()" in destructor#906
Merged
Conversation
Replace "delete" with heap_caps_free() since data was not allocated with "new"
Owner
|
Interesting pick up. What is the practical impact? Only the pointer is deleted and the memory allocation actually remains? |
Contributor
Author
|
AFAIK new and malloc (family) do not use the same memory pool. There were issues with destruction of driver on ESP32-S3, possibly related but I did not investigate in detail. "delete" (without "new") immediately jumped out. |
Owner
|
Thanks for this contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace "delete" with heap_caps_free() since data was not allocated with "new"