Fix: Properly set line_decoder in HUB75_I2S_CFG struct constructor#919
Merged
Conversation
Owner
|
Thank you for this! |
Copilot AI
added a commit
to CosmicBitflip/ESP32-HUB75-MatrixPanel-DMA
that referenced
this pull request
Apr 26, 2026
Also incorporates upstream fix: line_decoder properly initialized in HUB75_I2S_CFG constructor (upstream PR mrcodetastic#919 / commit 7bf3b6c). Changes vs feat/single-scan-support: - No runtime bitmask variables or initBitmasks() - BITMASK_* #defines used directly - No duplicate ROWS_PER_FRAME setup in setupDMA() - setCfg() is the only place - MATRIX_ROWS_IN_PARALLEL stays as #define 2; ROWS_PER_FRAME set to mx_height for single-scan - All existing pixel-write paths (updateMatrixDMABuffer(x,y), hlineDMA, vlineDMA, clearFrameBuffer) work correctly without modification once ROWS_PER_FRAME = mx_height Agent-Logs-Url: https://github.com/CosmicBitflip/ESP32-HUB75-MatrixPanel-DMA/sessions/aaf0d423-7511-4923-a2af-42ae4b95820c Co-authored-by: CosmicBitflip <43938054+CosmicBitflip@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a minor typo in the HUB75_I2S_CFG struct constructor. The temporary variable _line_drv is set to TYPE138 by default, but then the line_decoder value is not included in the actual constructor line.
This was causing a very strange issue in one of my projects, where enabling on chip PSRAM (on an ESP32S3) would sometimes result in the row scanning of the display breaking entirely. Every 8th row after the first one would be displayed, with each subsequent row being rendered on top of the previous 8th row.
For whatever reason, with PSRAM enabled on my particular firmware setup, this value was more likely to end up in a section of RAM that was not BSS initialized, and if it ended up set to '3' (or 'SM5266P' mode), the row scanning would break.