This repository was archived by the owner on Feb 10, 2025. It is now read-only.
Open
Conversation
veselyn
force-pushed
the
darwin-support
branch
from
1a75da0 to
998374e
Compare
mrjones2014
reviewed
Feb 6, 2025
| TMP_FILE="$_truePath.tmp" | ||
|
|
||
| mkdir -p "$(dirname "$_truePath")" | ||
| # shellcheck disable=SC2050 |
Owner
There was a problem hiding this comment.
out of curiosity, do you have shellcheck running inside the strings somehow?
mrjones2014
reviewed
Feb 6, 2025
| @@ -0,0 +1,78 @@ | |||
| toplevel @ { | |||
Owner
There was a problem hiding this comment.
can you explain what this toplevel @ is for?
Owner
|
The code here mostly looks good but I do not have a mac I can test this on. Would you be willing to add a CI job that uses GitHub's mac runners and runs a test macOS configuration? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Amazing project! I want to use it on my Mac as well so I put together a Darwin module.
It mostly works but occasionally fails due to some permission error. I'll try to figure out why when I find some free time, or somebody else can take a look.Problem was that the daemon and the activation script were running simultaneously and causing race conditions. Fixed in 37cb44d.