Skip to content

fix: nosql injection in customer password reset #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
peleg-development wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: nosql injection in customer password reset #290

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions routes/customer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ router.post('/customer/create', async (req, res) => {
}

// check for existing customer
const customer = await db.customers.findOne({ email: req.body.email });
const customer = await db.customers.findOne({ email: mongoSanitize(req.body.email) });
if(customer){
res.status(400).json({
message: 'A customer already exists with that email address'
Expand Down Expand Up @@ -508,7 +508,7 @@ router.post('/customer/forgotten_action', apiLimiter, async (req, res) => {
const passwordToken = randtoken.generate(30);

// find the user
const customer = await db.customers.findOne({ email: req.body.email });
const customer = await db.customers.findOne({ email: mongoSanitize(req.body.email) });
try{
if(!customer){
// if don't have an email on file, silently fail
Expand All @@ -518,7 +518,7 @@ router.post('/customer/forgotten_action', apiLimiter, async (req, res) => {
return;
}
const tokenExpiry = Date.now() + 3600000;
await db.customers.updateOne({ email: req.body.email }, { $set: { resetToken: passwordToken, resetTokenExpiry: tokenExpiry } }, { multi: false });
await db.customers.updateOne({ email: mongoSanitize(req.body.email) }, { $set: { resetToken: passwordToken, resetTokenExpiry: tokenExpiry } }, { multi: false });
// send forgotten password email
const mailOpts = {
to: req.body.email,
Expand Down