fix(install): surface valid-agent hint in unknown-agent error - #813
Open
sunilkumarvalmiki wants to merge 1 commit into
Open
fix(install): surface valid-agent hint in unknown-agent error#813sunilkumarvalmiki wants to merge 1 commit into
sunilkumarvalmiki wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve the unknown-agent error message to surface valid-agent discovery hints, closing the asymmetry with the unknown-tool error path.
What this PR does
--list agentshint to the unknown-agent-in-agents-file error path.test-agent-selection.shwith a new case asserting the error surfaces a valid-option hint.test-agent-selection.sh($INSTALLERwas unquoted, causing the test to fail on repo paths containing spaces).Checklist
test-agent-selection.shpasses all cases;check-tools.sh,check-divisions.sh, andcheck-runbooks.shpass.Evidence
check-tools.sh: PASSED (16 tools consistent)check-divisions.sh: PASSED (18 divisions consistent)check-runbooks.sh: PASSED (4 runbooks, 64 agent slug references)