This repository was archived by the owner on Apr 7, 2020. It is now read-only.
updated Electron to 4.0.5#85
Open
cyril23 wants to merge 1 commit into
Open
Conversation
Owner
|
Master is on 4.0.6, but I haven't had time to release it as v4 renders blank PDF-s on higher loads. Maybe it is an issue with test setup. |
Author
How to check if PDFs with blank pages have been created?
edit: have you opened up an issue for this? |
Owner
|
@cyril23 The tests fail, I haven't created an issue, it returns 695 bytes big valid blank PDF file, you can check it like this - https://github.com/msokk/electron-render-service/blob/master/__tests__/stability.js#L30, have to slice the beginning bytes out as that bit contains a timestamp. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have bumped Electron to 4.0.5, because I was getting error
signal 11 SEGV_MAPERRwith the old version which will not be fixed due to old Electron version: electron/electron#9236It runs fine so far, since 4 weeks and about 200 PDFs / day.
edit: I use HTML to PDF only (no PNG or whatever)