Merged
Conversation
bredelings
force-pushed
the
fix-windows-long
branch
9 times, most recently
from
7a12f98 to
d99b38d
Compare
bredelings
force-pushed
the
fix-windows-long
branch
from
d99b38d to
818a09e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apparently NCL is casting pointers to
long, which fails on windows64 becauselongis only 32 bits there and cannot fit a pointer. This is then causing failures trying to build tensorphylo on windows.Ideally we'd go through and convert
long->std::int64_tandunsigned long->std::uing64_tjust like we did with revbayes. But this PR is a first step to make NCL compile on windows.