Added ability to retrieve file's sender#167
Open
Ijatsu wants to merge 2 commits intomuaz-khan:masterfrom
Ijatsu:master
Open
Added ability to retrieve file's sender#167Ijatsu wants to merge 2 commits intomuaz-khan:masterfrom Ijatsu:master
Ijatsu wants to merge 2 commits intomuaz-khan:masterfrom
Ijatsu:master
Conversation
Contributor
Author
|
For simplicity it only provides information about sender at fileStart. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I might be wrong, but I didn't manage to find a way to know who is the sender of a file, so I just put the userid in the file's data in receiver's side.
Is this userid the userid provided by webrtc or is it an information given by the remote client?
If it is given by the remote client then it is insecure.