Fixed MediaStreamRecorder audio bug#295
Open
kevin-frugier wants to merge 1 commit intomuaz-khan:masterfrom
Open
Fixed MediaStreamRecorder audio bug#295kevin-frugier wants to merge 1 commit intomuaz-khan:masterfrom
kevin-frugier wants to merge 1 commit intomuaz-khan:masterfrom
Conversation
…er the type can be used right away to change the mediastream
Owner
|
Can you please push these updates to MediaStreamRecorder repository? Ref: |
Author
|
Ok I've done it now : streamproc/MediaStreamRecorder#20 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In MediaStreamRecorder there is a (not so) dirty hack to record audio when the stream contains both video and audio (otherwise video/webm blobs are recorded).
The hack uses this.type which is not yet set (the propertiesMerge is only done after construction).
As a workaround I passed config.type to Recorder constructor since in MediaStreamRecorder the type can be used right away to change the mediastream.