feat(localrecall): gate all log messages under DEBUG flag - #12
Merged
mudler merged 2 commits intoFeb 23, 2026
Merged
Conversation
A no-op tool that forces the model to think about a message. Takes a message string input and echoes it back, useful for debugging or forcing explicit reasoning steps in the model.
- Add debugMode boolean that reads from DEBUG environment variable - Create debugLog() helper function that only prints when DEBUG=1 - Replace all log.Printf/log.Println calls with debugLog() - By default, no logs are emitted to preserve JSON-RPC stdio protocol Fixes: The LocalRecall MCP was corrupting JSON-RPC communication by emitting logs to stdout, causing the container to fail. Logs are now only shown when DEBUG=1 is set.
mudler
reviewed
Feb 23, 2026
| - mcp: wait | ||
| dockerfile: ./Dockerfile | ||
| context: ./ | ||
| - mcp: think |
Contributor
Author
|
I have applied the requested fixes - the branch is now rebased against the latest master branch. Awaiting further review. |
mudler
marked this pull request as ready for review
February 23, 2026 23:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The LocalRecall MCP was corrupting JSON-RPC communication by emitting logs to stdout, causing the container to fail as described in issue #10.
This PR introduces a debug logging mechanism:
Usage
Changes
Closes: #10