Updated Verifiable trait to enable unlimited veirifcations of all types by any user to any user. - #121
Open
jayenne wants to merge 7 commits into
Open
Updated Verifiable trait to enable unlimited veirifcations of all types by any user to any user.#121jayenne wants to merge 7 commits into
jayenne wants to merge 7 commits into
Conversation
…ne of Friendable with an added $message property along as it's own group 'type' options. The reason for not simply adding $message to Friendable is so that a user can have a seperate friends list/groups to those they would like to verify as genuine people with optional message and how they had 'met' them. The $message is optional as implementors may wish to log only the 'how' people know eachother rathen than including a feedback message too.
* Verifications: Added verifications as a new 'Verifiable' trait. It is an adapted clone of Friendable with an added $message property along as it's own group 'type' options. Nb: "Blocked" is not a part of the Verifiable trait, blocking should be handled by friendable as it currently is. The reason for not simply adding $message to Friendable is so that a user can have a seperate friends list/groups to those they would like to verify as genuine people with optional message and how they had 'met' them. The $message is optional as implementors may wish to log only the 'how' people know eachother rathen than including a feedback message too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have updated the Verifiable Trait and associated classes/migrations and tests to enablea user to verify another user with unlimited verifications of any type to a single user (and removed the associated config settings). I feel these restrictions are best placed in the hands of the user rather than bloating the package. I have also removed Verifiable's "Blocking" methods to avoid confusion/duplication with Friendable's Blocking.