Skip to content

Update docs for contributions#21

Open
electrachong wants to merge 5 commits intomasterfrom
ec/update-docs
Open

Update docs for contributions#21
electrachong wants to merge 5 commits intomasterfrom
ec/update-docs

Conversation

@electrachong
Copy link
Copy Markdown
Contributor

@electrachong electrachong commented Jul 12, 2022

Carthage archive script was also outdated

@electrachong electrachong requested a review from nidhik July 12, 2022 00:24
@electrachong electrachong marked this pull request as ready for review July 12, 2022 00:36
@@ -20,18 +23,27 @@ Then run `pod install`.

## Development
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's probably worth splitting this and the release section out into a README_INTERNAL like we do elsewhere https://github.com/muxinc/mux-stats-sdk-avplayer/blob/master/README_INTERNAL.md

* Delete the existing reference to `THEOplayerSDK.xcframework` in `MUXSDKStatsTHEOplayer/Frameworks`
* Drag and drop the downloaded `THEOplayerSDK.xcframework` from Finder into `MUXSDKStatsTHEOplayer/Frameworks`

https://user-images.githubusercontent.com/15208707/178379606-7ba319e0-88eb-4b92-ba54-e07ac8485cf7.mov
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you - this is very helpful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants