Log full encKey and hmacKey every time a message is sent - #102
Draft
GeorgeMcLellan wants to merge 7 commits into
Draft
Log full encKey and hmacKey every time a message is sent#102GeorgeMcLellan wants to merge 7 commits into
GeorgeMcLellan wants to merge 7 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOT TO BE MERGED INTO MASTER
To debug why the "HMAC Signature does not match" error is occurring since ios 18.1, I have added some logs to dump the entire encKey and hmacKey for every message that is sent from POS, along with the encrypted message and the HMAC signature.
This is just for debugging, not to be pushed to production.
Here are some random idea I have that might be good to identify:
spiMessageStamp.secretsdiffers to thesecretsproperty in SPIClient? Could there be issues that arise from having the secrets stored in two different locations (self.secrets&self.spiMessageStamp.secrets)?encKey/hmacKeyandencKeyData/hmacKeyData? We have previously added logs forencKey&hmacKeyand it appears these do not change when this hmac issue occurs. However, it isencKeyData&hmacKeyDatathat are actually used for encryption & HMAC. They are initialised when creating SPISecrets.