You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This commit improve the performance of the task page.
Background
When we have millions of tasks log, it will take a significant duration for loading the task page. When loading the task list, process_tasks will load task result for each task items while only the fail_count, pass_count, total, task_id, result_id of the task result are be used. And each of these fields can be computed by database.
Change Code
This commit refactor the process_tasks method in TasksView class, using group by statement and sum, count functions to compute these statistic fields at database.
Performance
This change has been applied in our intranet, and it improve the loading time of task page from 15s to 1s.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit improve the performance of the task page.
Background
When we have millions of tasks log, it will take a significant duration for loading the task page. When loading the task list,
process_taskswill load task result for each task items while only thefail_count,pass_count,total,task_id,result_idof the task result are be used. And each of these fields can be computed by database.Change Code
This commit refactor the
process_tasksmethod inTasksViewclass, usinggroup bystatement andsum,countfunctions to compute these statistic fields at database.Performance
This change has been applied in our intranet, and it improve the loading time of task page from 15s to 1s.