Skip to content

added SCRAPYD_SERVER HTTPS support - #230

Open
ritikkumarsahu wants to merge 1 commit into
my8100:masterfrom
ritikkumarsahu:master
Open

added SCRAPYD_SERVER HTTPS support#230
ritikkumarsahu wants to merge 1 commit into
my8100:masterfrom
ritikkumarsahu:master

Conversation

@ritikkumarsahu

Copy link
Copy Markdown

Currently Scrapydweb doesn't support Scrapyd Server hosted remotely with HTTPS. I have Added the support for https.

SCRAPYD_SERVERS = [
('', '', 'https', example.com', '443', '')
]

@pep8speaks

Copy link
Copy Markdown

Hello @ritikkumarsahu! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 393:121: E501 line too long (121 > 120 characters)

Line 183:121: E501 line too long (169 > 120 characters)

Line 20:121: E501 line too long (127 > 120 characters)

Line 56:121: E501 line too long (138 > 120 characters)
Line 69:121: E501 line too long (138 > 120 characters)

Line 287:121: E501 line too long (175 > 120 characters)

Line 368:121: E501 line too long (167 > 120 characters)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants