Skip to content

Use urlquote to allow passwords with special characters. - #235

Open
espoirMur wants to merge 1 commit into
my8100:masterfrom
espoirMur:master
Open

Use urlquote to allow passwords with special characters.#235
espoirMur wants to merge 1 commit into
my8100:masterfrom
espoirMur:master

Conversation

@espoirMur

Copy link
Copy Markdown

This change introduces the usage of urlquote to allow the use of passwords with special characters such as @.

Previously those characters were converted, changing the password and leat to authentication failures.

@coveralls

coveralls commented Aug 7, 2024

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 218f960e-2f76-429e-aa73-367d2e11b48e

Details

  • 1 of 3 (33.33%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 85.87%

Changes Missing Coverage Covered Lines Changed/Added Lines %
scrapydweb/utils/setup_database.py 1 3 33.33%
Totals Coverage Status
Change from base Build 1f9efb3c-a791-4498-b745-263362a8011e: 0.1%
Covered Lines: 3470
Relevant Lines: 4041

💛 - Coveralls

@codecov

codecov Bot commented Jun 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.82%. Comparing base (8de7ede) to head (323de74).
⚠️ Report is 10 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #235   +/-   ##
=======================================
  Coverage   85.82%   85.82%           
=======================================
  Files          34       34           
  Lines        4042     4043    +1     
=======================================
+ Hits         3469     3470    +1     
  Misses        573      573           
Files with missing lines Coverage Δ
scrapydweb/utils/setup_database.py 85.14% <100.00%> (+0.14%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants