Bug fix for GPIO under recent Linux kernel versions by romaricr · Pull Request #1562 · mysensors/MySensors

romaricr · 2024-03-13T06:41:10Z

Slight update of MySensors using libgpiod instead of all standard sysfs to map interrupts.

Using libgpiod

romaricr · 2024-03-13T13:13:18Z

Tested on my Raspberry PI / NRF24 gateway and working fine (with around 10 devices). Not tested on any other platform.

mfalkvidd · 2024-03-16T14:59:44Z

Nice work, thanks!

Attaching the restyling that the butler requests:
restyling.patch

Will add further comments shortly.

mfalkvidd

Adding review comments.

Do you know how long this interface has been available? The reason I'm asking is that we would prefer to not break older gateways (running on older Linux versions) if people upgrade.

mfalkvidd · 2024-03-16T15:01:10Z

 * - RF24_PA_MAX = 0dBm
 */
 #ifndef MY_RF24_PA_LEVEL
-#define MY_RF24_PA_LEVEL (RF24_PA_HIGH)


I'd prefer if we didn't change the default PA level in this PR, since it is not related to the change.

mfalkvidd · 2024-03-16T15:02:03Z

+//	FILE *fp = fopen("/sys/class/gpio/unexport", "w");
+//	if (fp == NULL) {
+//		logError("Unable to unexport pin %d for interrupt\n", gpioPin);
+//		exit(1);
+//	}
+//	fprintf(fp, "%d", gpioPin);
+//	fclose(fp);


Would you mind deleting those lines instead of commenting them? We have git for history.

mfalkvidd · 2024-03-16T15:04:28Z

 #include <stdint.h>

+// Ajout RRO
+#include <gpiod.h>


Do you know if this is installed by default on Raspberry Pi OS? If it is not, we should probably document how to install the dependency.

sudo apt-get install libgpiod-dev
Thanks to @zkarolyi in #1562 (comment)

romaricr · 2024-03-16T15:54:29Z

Styles and minor updates done.
For libgpiod, it has been there for a while. The release notes says 6 years.
About the potential dependency, you are right. It might require a sudo apt-get install libgpiod-dev to build and sudo apt-get install libgpiod to run. I have not tested what it looks like on a genuine installation.

For the documentation, sorry for my question but, how do I do that ?

mfalkvidd · 2024-03-16T21:14:43Z

Excellent, thanks!

6 years should be good enough, imo.

The documentation is not under version control unfortunately but I can add it to https://www.mysensors.org/build/raspberry

romaricr · 2024-03-18T13:02:08Z

Thank you to the reviewers.
I have seen some of the errors but I'm really not sure how to fix them ... Anyone could help ?

pompilir · 2024-08-19T17:42:52Z

Hi,
I was trying the fixed version after upgrading my RPI to the latest Raspbian OS. However, even after using the MySensors-gpio_fix version of the library I get "Could not open /sys/class/gpio/gpio16/direction"
Can you please help me?
Thanks in advance!

functionpointer · 2024-09-01T15:54:45Z

Just tested this on RPi Zero W with Raspbian Bookworm 32-bit kernel. Works great.

raks-dev · 2024-10-23T05:44:18Z

Hi, I was trying the fixed version after upgrading my RPI to the latest Raspbian OS. However, even after using the MySensors-gpio_fix version of the library I get "Could not open /sys/class/gpio/gpio16/direction" Can you please help me? Thanks in advance!

What is the SOC and CPU detected as part of the configure command execution?

E.g.

[SECTION] Detecting target machine.
  [OK] machine detected: SoC=BCM2712, Type=rpi5, CPU=aarch64.
[SECTION] Detecting SPI driver.
  [OK] SPI driver detected:BCM.

update:
I have proposed the solution which worked for me here: #1567

cvdenzen · 2025-01-19T21:53:51Z

like @raks-dev and @ricgyver I also still see the error "Could not open /sys/class/gpio/gpio9/direction". It seems that this pull request is not complete. The error is coming from file "hal/architecture/Linux/drivers/core/GPIO.cpp".
Anyone who can fix it (or maybe someone already has fixed it)?

raks-dev · 2025-01-20T07:55:28Z

@cvdenzen Refer this #1567
I have proposed the solution which worked for me.

cvdenzen · 2025-03-01T15:16:27Z

@cvdenzen Refer this #1567 I have proposed the solution which worked for me.
@raks-dev @ricgyver
The proposed solution doesn't work for me. I think the difference is that I am using a rpi4 and RFM69, and not the NRF24. The RFM69 code tries to set the interrupt pin to input mode. And that will result in the error "Could not open /sys/class/gpio/gpio16/direction".
I have a working solution, see https://github.com/cvdenzen/MySensors/tree/carl-gpiod1.

This solution includes:

detection of a raspberry Pi 4 under Linux 6.6 (in the configure script)
the edits by @romaricr .

Edit: I don't think the GPIO files are used with the changed configuration file (to detect the rpi4). I don't understand it, but at least it works for me.

poehlert · 2025-05-09T01:32:33Z

 		// Wait a bit
 		usleep(1000);
 	}



143-146 are now all unused vars from deleted code (fd, fName, c, count)

poehlert · 2025-05-09T01:32:54Z

-	fclose(fd);
+	char *chipname = "gpiochip0";
+	unsigned int line_num = gpioPin;
+	struct gpiod_line_event event;


this is unused as well

pompilir · 2025-07-21T13:32:24Z

After some time I was finally able to get MySensors running on a RPI3B serial gateway with bookworm os. I had to use this gpio_fix version of the library (the current dev branch does not compile). It is working reliably by almost a week with the sensors network I build in previous years. As steted, I had to install the libgpiod-dev library and use the following config lines:

./configure --my-transport=rfm69 --my-rfm69-frequency=433 --my-is-rfm69hw --my-gateway=serial --my-serial-is-pty --my-serial-pty=/dev/ttyUSB020 --soc=BCM2837 --cpu-flags="-march=armv8-a+crc -mtune=cortex-a53"_

All the other attempts (without the --soc=BCM2837 --cpu-flags="-march=armv8-a+crc -mtune=cortex-a53 instructions) failed. Hope this can push the merge of the fix in the official release of MySensors.

zkarolyi · 2025-08-16T10:29:04Z

For make this needed: sudo apt-get install libgpiod-dev

andreacioni · 2025-08-17T19:39:16Z

Just to confirm that I tried base development merged with romaric/gpio_fix and the build completed flawless. However this two additions are mandatory if you want this to work:

sudo apt-get install libgpiod-dev
configure flags: --soc=BCM2837 --cpu-flags="-march=armv8-a+crc -mtune=cortex-a53

Considering the relevance of this for RPi 5 user it should be documented somewhere.

zkarolyi · 2025-08-18T08:11:38Z

For RPi 4 I have these WORKING:

base development merged with romaric/gpio_fix
sudo apt-get install libgpiod-dev
sudo ./configure --my-gateway=mqtt --my-controller-ip-address=127.0.0.1 --my-mqtt-publish-topic-prefix=mysensors-out --my-mqtt-subscribe-topic-prefix=mysensors-in --my-mqtt-client-id=mygateway1 --my-mqtt-user=<...> --my-mqtt-password=<...> --soc=BCM2711 --cpu-flags="-march=armv8-a+crc -mtune=cortex-a72"

ONLY for IRQ:
But after a little fix in code to be able to make it with IRQ:
In /hal/architecture/Linux/MyHwLinuxGeneric.h:
from:

static __inline__ void __hwLock()
{
	pthread_mutex_lock(&hw_mutex);
}

to:

static __inline__ uint8_t __hwLock()
{
	pthread_mutex_lock(&hw_mutex);
	return 1;
}

I can not use IQR (--my-rf24-irq-pin=22). So working without it then.

Bug fix for GPIO under recent Linux kernel versions

2cfe833

Using libgpiod

mfalkvidd reviewed Mar 16, 2024

View reviewed changes

romaricr added 2 commits March 16, 2024 16:49

Updated for style and minors non functional changes

3dba00f

Minor changes

f157ed0

mfalkvidd requested review from a team, Yveaux, d00616, henrikekblad, scalz, tbowmo and tekka007 March 16, 2024 21:24

mfalkvidd mentioned this pull request Apr 19, 2024

Raspberry pi Gateway with IRQ doesn't compile #1557

Open

poehlert reviewed May 9, 2025

View reviewed changes

tekka007 added the Linux label Nov 16, 2025

functionpointer mentioned this pull request Apr 12, 2026

Linux: Migrate to libgpiod 2.x #1610

Open

Uh oh!

Uh oh!

Conversation

romaricr commented Mar 13, 2024

Uh oh!

romaricr commented Mar 13, 2024

Uh oh!

mfalkvidd commented Mar 16, 2024

Uh oh!

mfalkvidd left a comment

Choose a reason for hiding this comment

Uh oh!

mfalkvidd Mar 16, 2024

Choose a reason for hiding this comment

Uh oh!

mfalkvidd Mar 16, 2024

Choose a reason for hiding this comment

Uh oh!

mfalkvidd Mar 16, 2024

Choose a reason for hiding this comment

Uh oh!

mfalkvidd Aug 16, 2025

Choose a reason for hiding this comment

Uh oh!

romaricr commented Mar 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mfalkvidd commented Mar 16, 2024

Uh oh!

romaricr commented Mar 18, 2024

Uh oh!

pompilir commented Aug 19, 2024

Uh oh!

functionpointer commented Sep 1, 2024

Uh oh!

raks-dev commented Oct 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cvdenzen commented Jan 19, 2025

Uh oh!

raks-dev commented Jan 20, 2025

Uh oh!

cvdenzen commented Mar 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

poehlert May 9, 2025

Choose a reason for hiding this comment

Uh oh!

poehlert May 9, 2025

Choose a reason for hiding this comment

Uh oh!

pompilir commented Jul 21, 2025

Uh oh!

zkarolyi commented Aug 16, 2025

Uh oh!

andreacioni commented Aug 17, 2025

Uh oh!

zkarolyi commented Aug 18, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

romaricr commented Mar 16, 2024 •

edited

Loading

raks-dev commented Oct 23, 2024 •

edited

Loading

cvdenzen commented Mar 1, 2025 •

edited

Loading