relationNames and relatedNames tags update#35
Open
adrianbardan wants to merge 2 commits into
Open
Conversation
Contributor
|
Hi @adrianbardan, can you rebase your branch so its easy for everyone to just review the change? |
Contributor
Author
|
@tohenk can you check now? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes the conflicts from a previously closed pull request (#30) and extends the
relatedNamestag functionality to M2M relations.@DamienHarper and @tohenk please take a look and let me know if you think these changes have any ripple effects and affect in any way the updates that have been made in the meantime.
What's your method to test the library and make sure results are consistent after an update?