Skip to content

Set a unique url for each word#10

Open
mmai wants to merge 2 commits inton1k0:mainfrom
mmai:wordHash
Open

Set a unique url for each word#10
mmai wants to merge 2 commits inton1k0:mainfrom
mmai:wordHash

Conversation

@mmai
Copy link
Copy Markdown

@mmai mmai commented Jan 23, 2022

This updates the url with a unique hash so we can share words with links like this : https://mmai.github.io/wordlem/#fr-FR/6/AMd

I think this is an interesting feature, but I had to make changes in a lot of places, and I am still discovering elm, so I won't be disapointed if you don't merge this pull request :)

@n1k0
Copy link
Copy Markdown
Owner

n1k0 commented Jan 23, 2022

Thanks!

I didn't look at the code just yet but trying the feature using the demo link you provided, I'm getting this:

image

Also, on your version, closing the initial Help modal isn't persisted anymore in localStorage, so it shows up every time users refresh the page.

@mmai
Copy link
Copy Markdown
Author

mmai commented Jan 23, 2022

Ah yes, sorry. It should be fixed in the last commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants