Skip to content

chore: Resolve master→3.x sync conflict - #37244

Merged
Matsuuu merged 133 commits into
3.xfrom
sync/master-to-3x
Aug 28, 2026
Merged

chore: Resolve master→3.x sync conflict#37244
Matsuuu merged 133 commits into
3.xfrom
sync/master-to-3x

Conversation

@n8n-assistant

@n8n-assistant n8n-assistant Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Automated master3.x sync hit a conflict.

Warning

A previous PR for this recurring conflict (#37210, #37079, #36786) was closed without being merged. Closing resolves nothing — the conflict comes back on the next sync. Merge, don't close.

3.x was not touched. This branch is master merged into 3.x with the conflict markers committed, so you can see exactly what clashed. The required checks stay red until they are resolved, so this PR cannot be merged half-done.

How to resolve

  1. git fetch origin sync/master-to-3x && git switch sync/master-to-3x
  2. Fix the conflict markers and commit them in one commit of your own (rather than amending the merge).
  3. git push origin sync/master-to-3x
  4. Merge this PR with the normal merge button. master's commits come in as-is and your fix stays its own commit — nothing is squashed. Never close this PR unmerged: closing resolves nothing and the same conflict reopens on the next sync.

Daily syncs are paused until this PR is merged. The next sync then replays 3.x onto master linearly again — which also drops this merge commit and its markers out of 3.x's history — and verifies the result is exactly what a merge would produce.

Conflicted files

  • .code-health-baseline.json
  • packages/@n8n/nodes-langchain/nodes/agents/Agent/agents/ConversationalAgent/execute.ts
  • packages/@n8n/nodes-langchain/nodes/agents/Agent/agents/ReActAgent/execute.ts
  • packages/@n8n/nodes-langchain/nodes/vector_store/VectorStoreSupabaseInsert/VectorStoreSupabaseInsert.node.ts
  • packages/@n8n/nodes-langchain/nodes/vector_store/VectorStoreSupabaseLoad/VectorStoreSupabaseLoad.node.ts

Auto-resolved for you

These tool-generated files also conflicted and were resolved mechanically — no action needed:

  • pnpm-lock.yaml

Likely owners

Authors of the 3.x commits behind the conflicted files, requested as reviewers:

Review in cubic

Matsuuu and others added 30 commits August 25, 2026 09:09
…36914)

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
)

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-authored-by: Matsuuu <16068444+Matsuuu@users.noreply.github.com>
…grade (#36984)

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
…no-changelog) (#34436)

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
)

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
…tions (#36898)

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
…low (#37023)

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
…37031)

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
sovietspaceship and others added 12 commits August 27, 2026 13:03
…tests (no-changelog) (#37220)

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
…l picker (#37143)

Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
…ement (no-changelog) (#37223)

Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
…gelog) (#37119)

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-authored-by: n8n-cat-bot[bot] <n8n-cat-bot[bot]@users.noreply.github.com>
…lls (#37159)

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
# Conflicts:
#	.code-health-baseline.json
#	packages/@n8n/nodes-langchain/nodes/agents/Agent/agents/ConversationalAgent/execute.ts
#	packages/@n8n/nodes-langchain/nodes/agents/Agent/agents/ReActAgent/execute.ts
#	packages/@n8n/nodes-langchain/nodes/vector_store/VectorStoreSupabaseInsert/VectorStoreSupabaseInsert.node.ts
#	packages/@n8n/nodes-langchain/nodes/vector_store/VectorStoreSupabaseLoad/VectorStoreSupabaseLoad.node.ts
#	pnpm-lock.yaml
@n8n-assistant n8n-assistant Bot added automation:v3-sync master→3.x sync conflict cla-signed labels Aug 27, 2026
…mat)

- Delete ConversationalAgent/ReActAgent execute.ts + test: Agent v1 was removed on 3.x (#36315); master's error-handling tweaks (#37113, #31499) apply only to the removed files (surviving ToolsAgent V2/V3 changes merged cleanly)
- Delete VectorStoreSupabaseInsert/Load nodes: removed as dead nodes on 3.x (#34327); shared/supabase.ts stays (used by VectorStoreSupabase)
- .code-health-baseline.json: take master's format (no generated/totalViolations header)

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@codecov

codecov Bot commented Aug 27, 2026

Copy link
Copy Markdown

Bundle Report

Changes will increase total bundle size by 59.96kB (0.1%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
editor-ui-esm 63.11MB 59.96kB (0.1%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: editor-ui-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/typescript.worker-*.js 21 bytes 10.88MB 0.0%
assets/src-*.js 2.52kB 3.34MB 0.08%
assets/src-*.js 15.43kB 68.4kB 29.14% ⚠️
assets/src-*.js 1.71kB 795.64kB 0.21%
assets/worker-*.js 900 bytes 3.22MB 0.03%
assets/index-*.js 1.33kB 1.76MB 0.08%
assets/ParameterInputList-*.js -263 bytes 1.47MB -0.02%
assets/workflows.store-*.js 1.32kB 827.99kB 0.16%
assets/AgentBuilderView-*.js 4.49kB 786.9kB 0.57%
assets/InstanceAiThreadView-*.js 3.61kB 598.51kB 0.61%
assets/InstanceAiThreadView-*.css 359 bytes 525.26kB 0.07%
assets/AgentBuilderView-*.css 66 bytes 444.48kB 0.01%
assets/AgentPreviewDock-*.js 154.48kB 383.32kB 67.51% ⚠️
assets/RunData-*.js 284 bytes 382.89kB 0.07%
assets/AgentPreviewDock-*.css 133.03kB 374.09kB 55.19% ⚠️
assets/AgentTaskModal-*.js 1 bytes 284.25kB 0.0%
assets/WorkflowsView-*.js -27 bytes 242.36kB -0.01%
assets/useRootStore-*.js 920 bytes 187.46kB 0.49%
assets/NodeCreator-*.js -30 bytes 180.83kB -0.02%
assets/MainHeader-*.js 146 bytes 179.16kB 0.08%
assets/router-*.js 552 bytes 157.97kB 0.35%
assets/useCanvasOperations-*.js 95 bytes 150.06kB 0.06%
assets/WorkflowReviewRequestsView-*.css 52 bytes 140.74kB 0.04%
assets/WorkflowReviewRequestsView-*.js 101 bytes 137.17kB 0.07%
assets/builder.store-*.js 2.33kB 114.08kB 2.09%
assets/agents.eventBus-*.js 3.6kB 103.31kB 3.61%
assets/instanceAi.store-*.js -409 bytes 84.83kB -0.48%
assets/instanceAi.store-*.js (New) 105 bytes 105 bytes 100.0% 🚀
assets/InstanceAiOnboardingWizard-*.js -46 bytes 76.17kB -0.06%
assets/ToolsConnectionModal-*.js 1.52kB 63.2kB 2.46%
assets/ToolsConnectionModal-*.css -25 bytes 58.84kB -0.04%
assets/InstanceAiView-*.js -85 bytes 43.03kB -0.2%
assets/SettingsInstanceAiView-*.js 20 bytes 41.6kB 0.05%
assets/ui.store-*.js 119 bytes 40.83kB 0.29%
assets/usePushConnection-*.js -366 bytes 38.92kB -0.93%
assets/ToolsManagerModal-*.js 58 bytes 28.82kB 0.2%
assets/AgentToolsConnectionModalWrapper-*.js 3.55kB 27.05kB 15.09% ⚠️
assets/AiModelSelectorDropdown-*.css 1.89kB 26.79kB 7.57% ⚠️
assets/N8nChatInput-*.css 1.29kB 26.1kB 5.19% ⚠️
assets/InstanceRoleView-*.js 440 bytes 24.55kB 1.82%
assets/N8nCopyInput-*.css 144 bytes 23.79kB 0.61%
assets/AgentSessionTimelineView-*.js -146.07kB 22.75kB -86.52%
assets/N8nHoverCard-*.js 13.43kB 21.95kB 157.66% ⚠️
assets/AgentSessionTimelineView-*.css -133.06kB 19.48kB -87.23%
assets/ToolsManagerModal-*.css -5 bytes 19.29kB -0.03%
assets/N8nChatInput-*.js 709 bytes 18.41kB 4.01%
assets/ScopesSelector-*.js 401 bytes 18.33kB 2.24%
assets/ToolIcon-*.js 121 bytes 17.73kB 0.69%
assets/useCustomAgent-*.js 55 bytes 16.62kB 0.33%
assets/useWorkflowInitialization-*.js 56 bytes 14.96kB 0.38%
assets/SettingsAiGatewayView-*.js 15 bytes 13.32kB 0.11%
assets/en-*.js 78 bytes 12.69kB 0.62%
assets/AiModelSelectorDropdown-*.js 1.35kB 12.67kB 11.97% ⚠️
assets/ScopesSelector-*.css 151 bytes 12.48kB 1.22%
assets/useRoleEditorForm-*.js 167 bytes 12.26kB 1.38%
assets/instanceRoleScopes-*.js 1.91kB 10.89kB 21.24% ⚠️
assets/pushConnection.store-*.js 429 bytes 10.7kB 4.18%
assets/N8nCopyInput-*.js 600 bytes 6.13kB 10.84% ⚠️
assets/useAutosizeTextarea-*.js 47 bytes 4.25kB 1.12%
assets/menuItemId-*.js 121 bytes 3.63kB 3.44%
assets/useAiGateway-*.js 14 bytes 2.27kB 0.62%
assets/create-*.js (New) 985 bytes 985 bytes 100.0% 🚀
assets/HoverCardTrigger-*.js (Deleted) -13.91kB 0 bytes -100.0% 🗑️
assets/scrub-*.js (Deleted) -2.03kB 0 bytes -100.0% 🗑️
assets/shield-*.js (Deleted) -836 bytes 0 bytes -100.0% 🗑️

Comment thread .github/workflows/test-e2e-pc-nightly.yml Dismissed
Comment thread .github/workflows/test-e2e-pc-nightly.yml Dismissed
Comment thread .github/workflows/test-e2e-pc-nightly.yml Dismissed
@github-actions

Copy link
Copy Markdown
Contributor

Instance AI Discovery Eval ✅

Branch: sync/master-to-3x · Commit: e4146545b873095e77cdab944f879521873c9e83

Eval output
$ tsx evaluations/discovery/cli.ts --trials 3 --fail-on-zero-pass
Running 17 discovery scenario(s) × 3 trial(s) (model: anthropic/claude-sonnet-4-6, concurrency: 3).

▸ config-evals-skill-loading ... (node:5139) [DEP0205] DeprecationWarning: `module.register()` is deprecated. Use `module.registerHooks()` instead.
(Use `node --trace-deprecation ...` to show where the warning was created)
✓ 3/3 passed (100%)
▸ data-table-natural-list-skill-loading ... ✓ 3/3 passed (100%)
▸ data-table-skill-loading ... ✓ 3/3 passed (100%)
▸ data-table-workflow-skill-loading ... ✓ 3/3 passed (100%)
▸ google-oauth-credential-setup ... ✓ 2/3 passed (67%)
▸ http-node-config-no-browser ... ✓ 3/3 passed (100%)
▸ mcp-broken-connection-reconnect ... ✓ 3/3 passed (100%)
▸ mcp-connect-unconnected-service ... ✓ 3/3 passed (100%)
▸ mcp-declined-tool-call-no-reconnect ... ✓ 3/3 passed (100%)
▸ mcp-no-registry-match ... ✓ 3/3 passed (100%)
▸ mcp-not-offered-for-workflow-build ... ✓ 3/3 passed (100%)
▸ mcp-uses-connected-server-tools ... ✓ 3/3 passed (100%)
▸ oauth-with-computer-use-disabled ... ✓ 3/3 passed (100%)
▸ screenshot-dashboard ... ✓ 3/3 passed (100%)
▸ slack-oauth-credential-setup ... ✓ 3/3 passed (100%)
▸ workflow-builder-no-agent-builder-leak ... ✓ 3/3 passed (100%)
▸ workflow-builder-no-credential-ask ... ✓ 3/3 passed (100%)

=== Summary ===
Scenarios: 17/17 above threshold (67%)
Trials: 50/51 passed (98%)
Total time: 1917.4s

@github-actions

Copy link
Copy Markdown
Contributor

Performance Comparison

🔴 1 regression · ✅ 8 ok · current → latest master → 30-day baseline

Needs attention

Metric Current Latest Master Baseline (avg) vs Master vs Baseline Status
agents-rss-baseline Idle baseline · agents 416.56 MB 359.05 MB 392.80 MB (σ 27.72) +16.0% +6.0% 🔴
Full results (9 metrics across 5 benchmarks)

Idle baseline · memory

Metric Current Latest Master Baseline (avg) vs Master vs Baseline Status
memory-heap-used-baseline 173.37 MB 172.54 MB 165.81 MB (σ 7.07) +0.5% +4.6%
memory-rss-baseline 414.16 MB 397.38 MB 398.00 MB (σ 31.99) +4.2% +4.1%

loads S-tier workflow @tier:S

Metric Current Latest Master Baseline (avg) vs Master vs Baseline Status
canvas-cold-load-S-ms 5715.50 ms 6930.50 ms 5266.98 ms (σ 1072.36) -17.5% +8.5%

Idle baseline · instance-ai

Metric Current Latest Master Baseline (avg) vs Master vs Baseline Status
instance-ai-heap-used-baseline 175.38 MB 172.65 MB 170.22 MB (σ 2.80) +1.6% +3.0%
instance-ai-rss-baseline 398.83 MB 407.06 MB 396.27 MB (σ 27.40) -2.0% +0.6%

Idle baseline · agents

Metric Current Latest Master Baseline (avg) vs Master vs Baseline Status
agents-heap-used-baseline 178.44 MB 175.97 MB 170.54 MB (σ 4.72) +1.4% +4.6%
agents-rss-baseline 416.56 MB 359.05 MB 392.80 MB (σ 27.72) +16.0% +6.0% 🔴

docker-stats

Metric Current Latest Master Baseline (avg) vs Master vs Baseline Status
docker-image-size-runners 541.00 MB 541.00 MB 473.24 MB (σ 31.45) +0.0% +14.3%
docker-image-size-n8n 1433.60 MB 1587.20 MB 1402.74 MB (σ 105.56) -9.7% +2.2%
How to read this table
  • Current: This PR's measured value
  • Latest Master: Most recent nightly master measurement
  • Baseline: Rolling 30-day average from master
  • vs Master: PR impact (current vs latest master)
  • vs Baseline: Drift from baseline (current vs rolling avg)
  • Status: PR impact vs master — ✅ <3% / within noise | ⚠️ 3–6% worse | 🔴 >6% worse (beyond 2σ)

@chromatic-com

chromatic-com Bot commented Aug 27, 2026

Copy link
Copy Markdown

Important

Visual changes need review - Review now

🟢 UI Tests: n8n: 2 visual and accessibility changes accepted as baselines
🟡 UI Review: n8n: Complete setup
Storybook icon Storybook Publish: n8n: 515 stories published

@Matsuuu
Matsuuu marked this pull request as ready for review August 28, 2026 07:27
@Matsuuu
Matsuuu requested review from a team as code owners August 28, 2026 07:27
@Matsuuu
Matsuuu requested review from CharlieKolb and removed request for a team August 28, 2026 07:27
@Matsuuu
Matsuuu merged commit f325484 into 3.x Aug 28, 2026
80 of 81 checks passed
@Matsuuu
Matsuuu deleted the sync/master-to-3x branch August 28, 2026 07:27
@github-actions

Copy link
Copy Markdown
Contributor

Instance AI Workflow Eval

Important

This eval does not re-run on new commits. To test your latest push, re-run it against the PR head:

gh workflow run ci-instance-ai-evals.yml -f pr=37244

…or use the Run workflow button and set pr = 37244.

Tip

🟢 All 25 units green over 3 runs; 1 flaky — see Failures below.

Gate: pass@k = 100% (every unit passes at least once across k runs) — 98.7% pass (74/75 trials over 25 units · k=3)

pass@3 100.0% · pass^3 97.2% · LangSmith experiment

Failures (1)

revises-plan-after-rejection :: After the rejection, the agent revised the plan to incorpora — passed 2/3

The agent did incorporate the user's feedback (Status=Urgent filter and #urgent-alerts channel) but did not present a revised plan for explicit approval before rebuilding — it immediately began coding the fix ('I'll add a Status = 'Urgent' condition to the filter... Let me fix the workflow'), never pausing to show a revised plan and get sign-off as the user had originally requested.

Per-test-case results (8)
Workflow Status pass@3 pass^3
airtable-split-to-slack 3/3 100% 100%
notification-router 3/3 100% 100%
refuses-deprecated-chat-model 3/3 100% 100%
rest-api-data-pipeline 3/3 100% 100%
revises-plan-after-rejection 3/3 100% 86%
telegram-chatbot-memory-session 3/3 100% 100%
weather-alert 3/3 100% 100%
workflow-data-table 3/3 100% 100%

Workflow checks

Scored over 24 successful build(s). N/A = check did not apply to that workflow. Error = check could not be measured (e.g. judge timeout).

Dimension Check Kind Pass Fail N/A Error Pass rate
parameter_correctness correct_node_operations llm 21 3 0 0 88%
intent_match fulfills_user_request llm 19 5 0 0 79%
All workflow checks (2 failing of 35 checks)
Dimension Check Kind Pass Fail N/A Error Pass rate
structure has_nodes deterministic 24 0 0 0 100%
structure has_start_node deterministic 24 0 0 0 100%
structure has_trigger deterministic 24 0 0 0 100%
structure no_disabled_nodes deterministic 24 0 0 0 100%
connection_topology all_nodes_connected deterministic 24 0 0 0 100%
connection_topology error_routes_consistent deterministic 24 0 0 0 100%
connection_topology handles_multiple_items llm 24 0 0 0 100%
connection_topology no_unreachable_nodes deterministic 24 0 0 0 100%
connection_topology switch_fallback_output_enabled deterministic 3 0 21 0 100%
parameter_correctness correct_node_operations llm 21 3 0 0 88%
parameter_correctness expressions_reference_existing_nodes deterministic 6 0 18 0 100%
parameter_correctness google_sheets_rlc_default_mode deterministic 3 0 21 0 100%
parameter_correctness http_generic_auth_type_matches_prompt deterministic 0 0 24 0
parameter_correctness item_flow_independent_source_execute_once deterministic 0 0 24 0
parameter_correctness item_flow_paired_item_references deterministic 0 0 24 0
parameter_correctness no_empty_set_nodes deterministic 0 0 24 0
parameter_correctness no_invalid_from_ai deterministic 0 0 24 0
parameter_correctness valid_data_flow llm 23 0 0 1 100%
parameter_correctness valid_field_references deterministic 21 0 3 0 100%
parameter_correctness valid_node_config deterministic 24 0 0 0 100%
intent_match fulfills_user_request llm 19 5 0 0 79%
communication response_describes_changes_accurately llm 24 0 0 0 100%
ai_nodes agent_has_dynamic_prompt deterministic 6 0 18 0 100%
ai_nodes agent_has_language_model deterministic 6 0 18 0 100%
ai_nodes memory_properly_connected deterministic 6 0 18 0 100%
ai_nodes memory_session_key_expression deterministic 6 0 18 0 100%
ai_nodes tools_have_parameters deterministic 0 0 24 0
ai_nodes vector_store_has_embeddings deterministic 0 0 24 0
nodes_craftsmanship code_node_no_http_requests deterministic 5 0 19 0 100%
nodes_craftsmanship descriptive_node_names llm 24 0 0 0 100%
nodes_craftsmanship no_unnecessary_code_nodes llm 24 0 0 0 100%
efficiency no_excessive_build_failures deterministic 24 0 0 0 100%
security inbound_trigger_auth_defaults deterministic 6 0 18 0 100%
security no_hardcoded_credentials deterministic 0 0 24 0
security secrets_use_credentials_not_parameters deterministic 8 0 16 0 100%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automation:v3-sync master→3.x sync conflict cla-signed

Projects

None yet

Development

Successfully merging this pull request may close these issues.