fix(Microsoft SQL Node): Fix TLS error when the IP is used to connect to the server - #37870
Open
RomanDavydchuk wants to merge 3 commits into
Open
fix(Microsoft SQL Node): Fix TLS error when the IP is used to connect to the server#37870RomanDavydchuk wants to merge 3 commits into
RomanDavydchuk wants to merge 3 commits into
Conversation
Contributor
PR review overviewBased on ownership of the 5 changed files in this PR:
|
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 4 files
Shadow auto-approve: would not auto-approve because issues were found.
Fix all with cubic | Re-trigger cubic
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
RomanDavydchuk
marked this pull request as ready for review
September 4, 2026 14:32
Contributor
There was a problem hiding this comment.
0 issues found across 2 files (changes from recent commits).
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Shadow auto-approve: would not auto-approve. Auto-approval blocked by 1 unresolved issue from previous reviews.
Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Microsoft SQL connections through an IP address fail when TLS is enabled on Node.js 25 or newer. The current
tediousdriver (used bymssqllibrary) uses the configured IP address as the TLS Server Name Indication (SNI). SNI only accepts hostnames. Older Node.js versions emitted a warning, but newer versions reject the connection. This updatesmssqlto 12.7.0 and pinstediousto 20.0.5, which contains the upstream fix. The updated driver omits SNI for IP addresses while continuing to validate the server certificate. Hostname-based connections keep their existing behavior.Changes in the library
Two breaking changes introduced by updating
mssqlto 12.7.0 do not affect n8n:mssql11 requires Node.js 18 or newer, which n8n already exceedsmssql12 no longer clones connection configuration objects, but n8n creates a new configuration for each pool and does not modify it afterwardExtra changes
This PR also converts raw credential data to numbers for
port,connectionTimeoutandrequestTimeoutfields. This is due to a bug introduced recently where values from numeric input fields are returned as string. A bug report is already created: https://linear.app/n8n/issue/ADO-5879/How to test
nvm i 26 && nvm use 26127.0.0.1(important: use the IP)mastersa1433SELECT 1;Related Linear tickets, Github issues, and Community forum posts
Fixes #37675
https://linear.app/n8n/issue/NODE-5878/community-issue-mssql-credential-tls-error
Review / Merge checklist
Backport to Beta,Backport to Stable, orBackport to v1(if the PR is an urgent fix that needs to be backported)