fix(core): Support streamed reasoning from custom AI endpoints (no-changelog) - #37875
Draft
Ryner01 wants to merge 1 commit into
Draft
fix(core): Support streamed reasoning from custom AI endpoints (no-changelog)#37875Ryner01 wants to merge 1 commit into
Ryner01 wants to merge 1 commit into
Conversation
Contributor
PR review overviewBased on ownership of the 5 changed files in this PR:
|
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
1 issue found across 5 files
Confidence score: 4/5
- In
packages/@n8n/agents/src/runtime/__tests__/model-factory.test.ts, the Backend regression test bypassescreateModel, so it can pass without verifying that custom endpoints reach the compatible provider; update it to exercisecreateModeland assert the resulting routing.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="packages/@n8n/agents/src/runtime/__tests__/model-factory.test.ts">
<violation number="1" location="packages/@n8n/agents/src/runtime/__tests__/model-factory.test.ts:890">
P2: Custom agent: **Backend**
This regression test bypasses `createModel`, so it does not verify that custom endpoints reach the compatible provider. The test still passes if the n8n registry routes the endpoint through the old provider; exercise `createModel({ id: 'custom/<model>', baseURL, apiKey })` and stream through the returned model.</violation>
</file>
Shadow auto-approve: would not auto-approve because issues were found.
Fix all with cubic | Re-trigger cubic
| expectedDeltas: [{ type: 'text-delta', id: 'txt-0', delta: 'The answer is 391.' }], | ||
| }, | ||
| ])('$name', async ({ content, expectedDeltas }) => { | ||
| const { createOpenAICompatible } = await vi.importActual< |
Contributor
There was a problem hiding this comment.
P2: Custom agent: Backend
This regression test bypasses createModel, so it does not verify that custom endpoints reach the compatible provider. The test still passes if the n8n registry routes the endpoint through the old provider; exercise createModel({ id: 'custom/<model>', baseURL, apiKey }) and stream through the returned model.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At packages/@n8n/agents/src/runtime/__tests__/model-factory.test.ts, line 890:
<comment>This regression test bypasses `createModel`, so it does not verify that custom endpoints reach the compatible provider. The test still passes if the n8n registry routes the endpoint through the old provider; exercise `createModel({ id: 'custom/<model>', baseURL, apiKey })` and stream through the returned model.</comment>
<file context>
@@ -864,6 +864,80 @@ describe('createModel', () => {
+ expectedDeltas: [{ type: 'text-delta', id: 'txt-0', delta: 'The answer is 391.' }],
+ },
+ ])('$name', async ({ content, expectedDeltas }) => {
+ const { createOpenAICompatible } = await vi.importActual<
+ typeof import('@ai-sdk/openai-compatible')
+ >('@ai-sdk/openai-compatible');
</file context>
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Contributor
Instance AI Discovery Eval ✅Branch: Eval output |
n8n-assistant
Bot
added
core
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Route custom OpenAI-compatible endpoints through the compatible provider. This lets Instance AI process streams that contain reasoning and text parts.
How to test
Related Linear tickets, Github issues, and Community forum posts
Review / Merge checklist
Backport to Beta,Backport to Stable, orBackport to v1(if the PR is an urgent fix that needs to be backported)🤖 PR Summary generated by AI