fix(editor): Clear tag loading state after failed requests - #37901
fix(editor): Clear tag loading state after failed requests#37901Suzu1Dev wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
No issues found across 2 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Shadow auto-approve: would not auto-approve. Auto-approval skipped because this PR is from an external contributor.
Re-trigger cubic
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Hey @Suzu1Dev, Thank you for your contribution. We appreciate the time and effort you’ve taken to submit this pull request. Before we can proceed, please ensure the following: • Your PR references the GitHub issue it fixes (or, for feature requests, a link to the corresponding community forum post). • Tests are included for any new functionality, logic changes or bug fixes. • The PR aligns with our contribution guidelines. Why the linked issue matters: Our teams pick up work from the issue, not from individual pull requests — the issue is what reaches them, with your PR linked to it. So please make sure the issue contains everything needed to judge the change: a clear problem description, reproduction steps, and the expected behaviour. If the issue is thin, add the missing context there rather than only in the PR description. Regarding new nodes: We no longer accept new nodes directly into the core codebase. Instead, we encourage contributors to follow our Community Node Submission Guide to publish nodes independently. If your node integrates with an AI service that you own or represent, please email nodes@n8n.io and we will be happy to discuss the best approach. About review timelines: While we plan to review it as soon as possible, we are currently unable to provide an exact timeframe. Our goal is to begin reviews within a month, but this may change depending on team priorities. We will reach out when the review begins. Please also note that other contributors may have opened pull requests for the same issue. We keep them all open so the reviewing team can choose the approach that fits best. Once the issue is resolved, the remaining pull requests are closed — this is not a judgement on the quality of your work, and we're grateful for it either way. Thank you again for contributing to n8n. |
Summary
A failed tag-list request leaves the tag store in a loading state. When the tag manager already has tags, the error message can appear while search and Add new remain disabled and the table keeps its loading overlay.
Reset loading in
finallyso it clears after success or failure. Keep the original error for the caller. Keep cached tags when a refresh fails. The shared implementation covers workflow tags and execution annotation tags.How to test
From
packages/frontend/editor-ui, run:pnpm test src/features/shared/tags/tags.store.test.ts src/features/shared/tags/components/WorkflowTagsDropdown.test.ts src/features/shared/tags/components/TagsDropdown.innerSelect.test.ts src/features/shared/tags/components/TagsManager/TagsView/TagsTableHeader.test.ts pnpm lint pnpm typecheckThe six new cases cover both store types:
Apply only this PR's test-file changes to base revision
909a6bc60aaaf926653a5f802f6a503f73c2a439to reproduce the failure. Run the tag-store suite. Four cases fail and ten pass. Each failure shows thatisLoadingremainstrueafter the API rejects. With the production fix, all 14 store cases pass. The 12 related component cases also pass.The tests mock the tag API. No live service is required. Browser interaction was not used for validation. The UI effects in the summary follow from the component bindings.
Local validation also passed editor lint and typecheck, repository typecheck, and repository lint. The repository lint check combined package checks, 129 successful tasks, and two valid cached results. The initial main run reached Node's default heap limit in the CLI package. Recovery used an 8 GB heap setting.
Related Linear tickets, Github issues, and Community forum posts
Fixes #37900.
Internal tracking: https://linear.app/n8n/issue/GHC-9417.
Review / Merge checklist
Backport to Beta,Backport to Stable, orBackport to v1(if the PR is an urgent fix that needs to be backported)🤖 PR Summary generated by AI