Skip to content

fix(editor): Preserve node parameters when serialization cannot normalize them - #37912

Open
lorenzozanee wants to merge 1 commit into
n8n-io:masterfrom
lorenzozanee:fix/preserve-ssh-parameters
Open

fix(editor): Preserve node parameters when serialization cannot normalize them#37912
lorenzozanee wants to merge 1 commit into
n8n-io:masterfrom
lorenzozanee:fix/preserve-ssh-parameters

Conversation

@lorenzozanee

@lorenzozanee lorenzozanee commented Sep 5, 2026

Copy link
Copy Markdown

Summary

Preserve existing node parameters when workflow serialization cannot normalize them. This prevents untouched node configuration from being replaced with an empty object when another node is edited and the workflow is saved.

How to test

From packages/frontend/editor-ui, run:

pnpm test src/app/utils/nodes/nodeTransforms.test.ts

The regression test covers a known SSH node whose parameter normalization returns null.

Related Linear tickets, Github issues, and Community forum posts

Fixes #37688

Reviewers

Jan Kalkan, Tuukka Kantola

Review / Merge checklist

  • I have seen this code, I have run this code, and I take responsibility for this code.
  • PR title and summary are descriptive.
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with Backport to Beta, Backport to Stable, or Backport to v1 (if the PR is an urgent fix that needs to be backported)

Review in cubic

@n8n-assistant

n8n-assistant Bot commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

CLA signatures required

Thank you for your submission! We really appreciate it.
Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Contributors who still need to sign:

Once signed, comment /cla-check on this PR to re-run verification.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Shadow auto-approve: would not auto-approve. Auto-approval skipped because this PR is from an external contributor.

Re-trigger cubic

@n8n-assistant n8n-assistant Bot added community Authored by a community member triage:pending Waiting to be triaged labels Sep 5, 2026
@n8n-assistant

n8n-assistant Bot commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Hey @lorenzozanee,

Thank you for your contribution. We appreciate the time and effort you’ve taken to submit this pull request.

Before we can proceed, please ensure the following: • Your PR references the GitHub issue it fixes (or, for feature requests, a link to the corresponding community forum post). • Tests are included for any new functionality, logic changes or bug fixes. • The PR aligns with our contribution guidelines.

Why the linked issue matters: Our teams pick up work from the issue, not from individual pull requests — the issue is what reaches them, with your PR linked to it. So please make sure the issue contains everything needed to judge the change: a clear problem description, reproduction steps, and the expected behaviour. If the issue is thin, add the missing context there rather than only in the PR description.

Regarding new nodes: We no longer accept new nodes directly into the core codebase. Instead, we encourage contributors to follow our Community Node Submission Guide to publish nodes independently.

If your node integrates with an AI service that you own or represent, please email nodes@n8n.io and we will be happy to discuss the best approach.

About review timelines: While we plan to review it as soon as possible, we are currently unable to provide an exact timeframe. Our goal is to begin reviews within a month, but this may change depending on team priorities. We will reach out when the review begins.

Please also note that other contributors may have opened pull requests for the same issue. We keep them all open so the reviewing team can choose the approach that fits best. Once the issue is resolved, the remaining pull requests are closed — this is not a judgement on the quality of your work, and we're grateful for it either way.

Thank you again for contributing to n8n.

@n8n-assistant n8n-assistant Bot added triage:in-progress Triage is in progress and removed triage:pending Waiting to be triaged labels Sep 5, 2026
@n8n-assistant

n8n-assistant Bot commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Before this PR can be triaged, please take a look at the failing checks and fix them. If the failures don't look related to your changes, rebasing onto the latest master often clears them up.

Once the checks pass, this PR will automatically be picked up for triage again. If you have questions or run into trouble, reply here and we'll help.

@n8n-assistant n8n-assistant Bot added triage:needs-info and removed triage:in-progress Triage is in progress labels Sep 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community Authored by a community member triage:needs-info

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Saving workflow clears SSH node parameters that were not edited

1 participant