feat: Add proper support for fibers#157
Open
farnoy wants to merge 1 commit into
Open
Conversation
This still has all the downsides of thread migrations, but works well with single threaded executors. It was tested on tokio's current_thread. Fixes nagisa#35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This still has all the downsides of thread migrations, but works well with single threaded executors. It was tested on tokio's current_thread.
Fixes #35
In the screenshot, I used it to prove that broadcasting on a channel -> yield does what I needed. It schedules the receivers to do synchronous
try_iountilEWOULDBLOCK👌.Implementation notes: I mostly copied all the boilerplate from plotting, and wired it up to
tracingto capture by span name. Completely untested on multithreaded schedulers, I assume it succeeds in capturing but is nonsensical around thread migrations. This was already a problem though, I don't think this change regresses on that.