feat: add duration_ms and rename ids to upserted_ids in drain.undertow payload#8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wraps the
undertow_on_draincall in a smallmeasure_mshelper and addsduration_msto thedrain.undertowpayload, so subscribers can see how long a handler actually took. While touching that payload shape, also renamedidstoupserted_ids(both the handler's second positional arg and the notification key) so it reads unambiguously next todeleted_ids. Pre-1.0 breaking changes are treated as normal here (same as the 0.1.x -> 0.2.x store-adapter rename), so this stays a plainfeat:with the migration step documented in UPGRADING.md rather than a!bump.