Skip to content

Fix ZK proof validation - #5026

Merged
mergify[bot] merged 3 commits into
mainfrom
tiago/masp-drain-fix
Aug 7, 2026
Merged

Fix ZK proof validation#5026
mergify[bot] merged 3 commits into
mainfrom
tiago/masp-drain-fix

Conversation

@sug0

@sug0 sug0 commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

Describe your changes

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

@github-actions github-actions Bot added the breaking:api public API breaking change label Aug 6, 2026
@sug0
sug0 force-pushed the tiago/masp-drain-fix branch from 44bc44e to 0ac801b Compare August 6, 2026 13:51
@sug0 sug0 added the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label Aug 6, 2026
@codecov

codecov Bot commented Aug 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@sug0
sug0 requested a review from Fraccaman August 6, 2026 15:03
@mergify mergify Bot added the queued label Aug 6, 2026
@mergify

mergify Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Merge Queue Status

  • Entered queue2026-08-06 15:13 UTC · Rule: main-queue · triggered by rule automatic merge to main or backport branch
  • Checks failed · on draft merge queue: checking main (e6f207c) and #5026 together #5028
  • 🚫 Left the queue2026-08-06 15:33 UTC · at 0ac801b06baf3951c99a1a0611bccbefb36271a4

This pull request spent 20 minutes 4 seconds in the queue, including 18 minutes 40 seconds running CI.

Waiting for
  • any of: [🛡 GitHub branch protection]
    • check-neutral = test-e2e-with-device-automation
    • check-skipped = test-e2e-with-device-automation
    • check-success = test-e2e-with-device-automation
  • any of: [🛡 GitHub branch protection]
    • check-neutral = test-e2e (0)
    • check-skipped = test-e2e (0)
    • check-success = test-e2e (0)
  • any of: [🛡 GitHub branch protection]
    • check-neutral = test-e2e (1)
    • check-skipped = test-e2e (1)
    • check-success = test-e2e (1)
  • any of: [🛡 GitHub branch protection]
    • check-neutral = test-e2e (2)
    • check-skipped = test-e2e (2)
    • check-success = test-e2e (2)
  • any of: [🛡 GitHub branch protection]
    • check-neutral = test-e2e (3)
    • check-skipped = test-e2e (3)
    • check-success = test-e2e (3)
  • any of: [🛡 GitHub branch protection]
    • check-neutral = test-e2e (4)
    • check-skipped = test-e2e (4)
    • check-success = test-e2e (4)
  • any of: [🛡 GitHub branch protection]
    • check-neutral = test-integration
    • check-skipped = test-integration
    • check-success = test-integration
All conditions
  • any of [🛡 GitHub branch protection]:
    • check-neutral = test-e2e-with-device-automation
    • check-skipped = test-e2e-with-device-automation
    • check-success = test-e2e-with-device-automation
  • any of [🛡 GitHub branch protection]:
    • check-neutral = test-e2e (0)
    • check-skipped = test-e2e (0)
    • check-success = test-e2e (0)
  • any of [🛡 GitHub branch protection]:
    • check-neutral = test-e2e (1)
    • check-skipped = test-e2e (1)
    • check-success = test-e2e (1)
  • any of [🛡 GitHub branch protection]:
    • check-neutral = test-e2e (2)
    • check-skipped = test-e2e (2)
    • check-success = test-e2e (2)
  • any of [🛡 GitHub branch protection]:
    • check-neutral = test-e2e (3)
    • check-skipped = test-e2e (3)
    • check-success = test-e2e (3)
  • any of [🛡 GitHub branch protection]:
    • check-neutral = test-e2e (4)
    • check-skipped = test-e2e (4)
    • check-success = test-e2e (4)
  • any of [🛡 GitHub branch protection]:
    • check-neutral = test-integration
    • check-skipped = test-integration
    • check-success = test-integration
  • github-review-approved [🛡 GitHub branch protection]
  • any of [🛡 GitHub branch protection]:
    • check-success = check-benchmarks
    • check-neutral = check-benchmarks
    • check-skipped = check-benchmarks
  • any of [🛡 GitHub branch protection]:
    • check-success = check-packages
    • check-neutral = check-packages
    • check-skipped = check-packages
  • any of [🛡 GitHub branch protection]:
    • check-success = build-binaries
    • check-neutral = build-binaries
    • check-skipped = build-binaries
  • any of [🛡 GitHub branch protection]:
    • check-success = build-wasm (wasm-for-tests, build-wasm-tests-scripts, wasm_for_tests/*.wasm)
    • check-neutral = build-wasm (wasm-for-tests, build-wasm-tests-scripts, wasm_for_tests/*.wasm)
    • check-skipped = build-wasm (wasm-for-tests, build-wasm-tests-scripts, wasm_for_tests/*.wasm)
  • any of [🛡 GitHub branch protection]:
    • check-success = lints
    • check-neutral = lints
    • check-skipped = lints
  • any of [🛡 GitHub branch protection]:
    • check-success = rust-docs
    • check-neutral = rust-docs
    • check-skipped = rust-docs
  • any of [🛡 GitHub branch protection]:
    • check-success = test-wasm
    • check-neutral = test-wasm
    • check-skipped = test-wasm
  • any of [🛡 GitHub branch protection]:
    • check-success = test-unit
    • check-neutral = test-unit
    • check-skipped = test-unit
  • any of [🛡 GitHub branch protection]:
    • check-neutral = Mergify Merge Protections
    • check-skipped = Mergify Merge Protections
    • check-success = Mergify Merge Protections

Reason

The merge conditions cannot be satisfied due to failing checks

  • check-benchmarks
  • check-packages
  • build-binaries
  • build-wasm (wasm-for-tests, build-wasm-tests-scripts, wasm_for_tests/*.wasm)
  • lints
  • rust-docs
  • test-wasm
  • test-e2e (4)
  • test-unit
  • Mergify Merge Protections

Failing checks:

Hint

You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio queue comment.

Requeued — the merge queue status continues in this comment ↓.

@mergify

mergify Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Hey @sug0, your pull request has been dequeued due to the following reason: CHECKS_FAILED.
Sorry about that, but you can requeue the PR by using @mergifyio requeue if you think this was a mistake.

@mergify mergify Bot added dequeued and removed queued labels Aug 6, 2026
@sug0

sug0 commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator Author

@Mergifyio requeue

@mergify

mergify Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Merge Queue Status

This pull request spent 3 hours 4 minutes 49 seconds in the queue, including 3 hours 3 minutes 48 seconds running CI.

Waiting for
  • any of: [🛡 GitHub branch protection]
    • check-neutral = test-e2e-with-device-automation
    • check-skipped = test-e2e-with-device-automation
    • check-success = test-e2e-with-device-automation
  • any of: [🛡 GitHub branch protection]
    • check-neutral = check-benchmarks
    • check-skipped = check-benchmarks
    • check-success = check-benchmarks
  • any of: [🛡 GitHub branch protection]
    • check-neutral = check-packages
    • check-skipped = check-packages
    • check-success = check-packages
  • any of: [🛡 GitHub branch protection]
    • check-neutral = build-binaries
    • check-skipped = build-binaries
    • check-success = build-binaries
  • any of: [🛡 GitHub branch protection]
    • check-neutral = build-wasm (wasm-for-tests, build-wasm-tests-scripts, wasm_for_tests/*.wasm)
    • check-skipped = build-wasm (wasm-for-tests, build-wasm-tests-scripts, wasm_for_tests/*.wasm)
    • check-success = build-wasm (wasm-for-tests, build-wasm-tests-scripts, wasm_for_tests/*.wasm)
  • any of: [🛡 GitHub branch protection]
    • check-neutral = lints
    • check-skipped = lints
    • check-success = lints
  • any of: [🛡 GitHub branch protection]
    • check-neutral = rust-docs
    • check-skipped = rust-docs
    • check-success = rust-docs
  • any of: [🛡 GitHub branch protection]
    • check-neutral = test-wasm
    • check-skipped = test-wasm
    • check-success = test-wasm
  • any of: [🛡 GitHub branch protection]
    • check-neutral = test-e2e (0)
    • check-skipped = test-e2e (0)
    • check-success = test-e2e (0)
  • any of: [🛡 GitHub branch protection]
    • check-neutral = test-e2e (1)
    • check-skipped = test-e2e (1)
    • check-success = test-e2e (1)
  • any of: [🛡 GitHub branch protection]
    • check-neutral = test-e2e (2)
    • check-skipped = test-e2e (2)
    • check-success = test-e2e (2)
  • any of: [🛡 GitHub branch protection]
    • check-neutral = test-e2e (3)
    • check-skipped = test-e2e (3)
    • check-success = test-e2e (3)
  • any of: [🛡 GitHub branch protection]
    • check-neutral = test-e2e (4)
    • check-skipped = test-e2e (4)
    • check-success = test-e2e (4)
  • any of: [🛡 GitHub branch protection]
    • check-neutral = test-integration
    • check-skipped = test-integration
    • check-success = test-integration
  • any of: [🛡 GitHub branch protection]
    • check-neutral = test-unit
    • check-skipped = test-unit
    • check-success = test-unit
All conditions
  • any of [🛡 GitHub branch protection]:
    • check-neutral = test-e2e-with-device-automation
    • check-skipped = test-e2e-with-device-automation
    • check-success = test-e2e-with-device-automation
  • any of [🛡 GitHub branch protection]:
    • check-neutral = check-benchmarks
    • check-skipped = check-benchmarks
    • check-success = check-benchmarks
  • any of [🛡 GitHub branch protection]:
    • check-neutral = check-packages
    • check-skipped = check-packages
    • check-success = check-packages
  • any of [🛡 GitHub branch protection]:
    • check-neutral = build-binaries
    • check-skipped = build-binaries
    • check-success = build-binaries
  • any of [🛡 GitHub branch protection]:
    • check-neutral = build-wasm (wasm-for-tests, build-wasm-tests-scripts, wasm_for_tests/*.wasm)
    • check-skipped = build-wasm (wasm-for-tests, build-wasm-tests-scripts, wasm_for_tests/*.wasm)
    • check-success = build-wasm (wasm-for-tests, build-wasm-tests-scripts, wasm_for_tests/*.wasm)
  • any of [🛡 GitHub branch protection]:
    • check-neutral = lints
    • check-skipped = lints
    • check-success = lints
  • any of [🛡 GitHub branch protection]:
    • check-neutral = rust-docs
    • check-skipped = rust-docs
    • check-success = rust-docs
  • any of [🛡 GitHub branch protection]:
    • check-neutral = test-wasm
    • check-skipped = test-wasm
    • check-success = test-wasm
  • any of [🛡 GitHub branch protection]:
    • check-neutral = test-e2e (0)
    • check-skipped = test-e2e (0)
    • check-success = test-e2e (0)
  • any of [🛡 GitHub branch protection]:
    • check-neutral = test-e2e (1)
    • check-skipped = test-e2e (1)
    • check-success = test-e2e (1)
  • any of [🛡 GitHub branch protection]:
    • check-neutral = test-e2e (2)
    • check-skipped = test-e2e (2)
    • check-success = test-e2e (2)
  • any of [🛡 GitHub branch protection]:
    • check-neutral = test-e2e (3)
    • check-skipped = test-e2e (3)
    • check-success = test-e2e (3)
  • any of [🛡 GitHub branch protection]:
    • check-neutral = test-e2e (4)
    • check-skipped = test-e2e (4)
    • check-success = test-e2e (4)
  • any of [🛡 GitHub branch protection]:
    • check-neutral = test-integration
    • check-skipped = test-integration
    • check-success = test-integration
  • any of [🛡 GitHub branch protection]:
    • check-neutral = test-unit
    • check-skipped = test-unit
    • check-success = test-unit
  • github-review-approved [🛡 GitHub branch protection]
  • any of [🛡 GitHub branch protection]:
    • check-neutral = Mergify Merge Protections
    • check-skipped = Mergify Merge Protections
    • check-success = Mergify Merge Protections

Reason

The merge conditions cannot be satisfied due to failing checks

  • lints
  • Mergify Merge Protections

Failing checks:

Hint

You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio queue comment.

Requeued — the merge queue status continues in this comment ↓.

@mergify

mergify Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Hey @sug0, your pull request has been dequeued due to the following reason: CHECKS_FAILED.
Sorry about that, but you can requeue the PR by using @mergifyio requeue if you think this was a mistake.

@mergify mergify Bot added dequeued and removed queued labels Aug 6, 2026
@sug0
sug0 force-pushed the tiago/masp-drain-fix branch from 0ac801b to c1f4df8 Compare August 7, 2026 08:49
@mergify mergify Bot added queued and removed dequeued labels Aug 7, 2026
@mergify

mergify Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Merge Queue Status

  • Entered queue2026-08-07 09:26 UTC · Rule: main-queue · triggered by rule automatic merge to main or backport branch
  • Checks passed · on draft merge queue: checking main (e6f207c) and #5026 together #5030
  • Merged2026-08-07 10:01 UTC · at c1f4df87140e7229bdcf7dfd6f79b3c66cbdd602 · merge

This pull request spent 35 minutes 3 seconds in the queue, including 33 minutes 53 seconds running CI.

Required conditions to merge
  • github-review-approved [🛡 GitHub branch protection]
  • any of [🛡 GitHub branch protection]:
    • check-success = test-e2e-with-device-automation
    • check-neutral = test-e2e-with-device-automation
    • check-skipped = test-e2e-with-device-automation
  • any of [🛡 GitHub branch protection]:
    • check-success = check-benchmarks
    • check-neutral = check-benchmarks
    • check-skipped = check-benchmarks
  • any of [🛡 GitHub branch protection]:
    • check-success = check-packages
    • check-neutral = check-packages
    • check-skipped = check-packages
  • any of [🛡 GitHub branch protection]:
    • check-success = build-binaries
    • check-neutral = build-binaries
    • check-skipped = build-binaries
  • any of [🛡 GitHub branch protection]:
    • check-success = build-wasm (wasm-for-tests, build-wasm-tests-scripts, wasm_for_tests/*.wasm)
    • check-neutral = build-wasm (wasm-for-tests, build-wasm-tests-scripts, wasm_for_tests/*.wasm)
    • check-skipped = build-wasm (wasm-for-tests, build-wasm-tests-scripts, wasm_for_tests/*.wasm)
  • any of [🛡 GitHub branch protection]:
    • check-success = lints
    • check-neutral = lints
    • check-skipped = lints
  • any of [🛡 GitHub branch protection]:
    • check-success = rust-docs
    • check-neutral = rust-docs
    • check-skipped = rust-docs
  • any of [🛡 GitHub branch protection]:
    • check-success = test-wasm
    • check-neutral = test-wasm
    • check-skipped = test-wasm
  • any of [🛡 GitHub branch protection]:
    • check-success = test-e2e (0)
    • check-neutral = test-e2e (0)
    • check-skipped = test-e2e (0)
  • any of [🛡 GitHub branch protection]:
    • check-success = test-e2e (1)
    • check-neutral = test-e2e (1)
    • check-skipped = test-e2e (1)
  • any of [🛡 GitHub branch protection]:
    • check-success = test-e2e (2)
    • check-neutral = test-e2e (2)
    • check-skipped = test-e2e (2)
  • any of [🛡 GitHub branch protection]:
    • check-success = test-e2e (3)
    • check-neutral = test-e2e (3)
    • check-skipped = test-e2e (3)
  • any of [🛡 GitHub branch protection]:
    • check-success = test-e2e (4)
    • check-neutral = test-e2e (4)
    • check-skipped = test-e2e (4)
  • any of [🛡 GitHub branch protection]:
    • check-success = test-integration
    • check-neutral = test-integration
    • check-skipped = test-integration
  • any of [🛡 GitHub branch protection]:
    • check-success = test-unit
    • check-neutral = test-unit
    • check-skipped = test-unit
  • any of [🛡 GitHub branch protection]:
    • check-neutral = Mergify Merge Protections
    • check-skipped = Mergify Merge Protections
    • check-success = Mergify Merge Protections

@mergify
mergify Bot merged commit ebda654 into main Aug 7, 2026
25 of 26 checks passed
@mergify
mergify Bot deleted the tiago/masp-drain-fix branch August 7, 2026 10:01
@mergify mergify Bot removed the queued label Aug 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking:api public API breaking change merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants