FFT buffer size independent from audio service buffer size#128
Open
stijnvanbeek wants to merge 1 commit intomainfrom
Open
FFT buffer size independent from audio service buffer size#128stijnvanbeek wants to merge 1 commit intomainfrom
stijnvanbeek wants to merge 1 commit intomainfrom
Conversation
Contributor
|
Thanks @stijnvanbeek! I'll take a look at it this weekend |
Member
|
Will merge when @lshoek approves and builds pass validation tonight. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR I make the FFT buffersize a property instead of using the audio buffer size. To accomplish this the FFTBuffer internally uses a circular buffer to stock up on incoming audio samples.
This guarantees that the number of FFT bins and resolution remains the same regardless of the audio device settings.
Also in rare occasions the host supplies different buffer sizes of audio to portaudio which caused the previous implementation to hit an assert.