Skip to content

Fix #506, Remove Dead Functions - #509

Open
arielswalker wants to merge 1 commit into
nasa:devfrom
arielswalker:fix-506-remove-dead-functions
Open

Fix #506, Remove Dead Functions#509
arielswalker wants to merge 1 commit into
nasa:devfrom
arielswalker:fix-506-remove-dead-functions

Conversation

@arielswalker

@arielswalker arielswalker commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Checklist (Please check before submitting)

Describe the contribution
Fixes #506

Testing performed
Ran the native_std commands which includes prep, install, runtest, and lcov. Compared these lcov results against the unchanged cFS bundle and found no changes. Ran the old build commands with unit tests enabled to ensure that the internal static code analysis tool no longer flags these functions. Also ran the bundle with -Wunused flags which only flagged unrelated macros.

Expected behavior changes
Removes 31 dead functions which are

  1. Any_cfdp_class_t
  2. Test_CF_WriteQueueCmd_When_CF_WriteHistoryDataToFile_FailsOnSecondCallAnd_wq_IsDownAnd_queue_IsActive_fd_IsPositive_Call_CF_WrappedClose_SendEventCloseAndRejectCommand
  3. Any_direction_t
  4. Any_condition_code_t
  5. Test_CF_WriteHistoryEntryToFile
  6. UT_DefaultHandler_CF_CFDP_ResetTransaction
  7. UT_DefaultHandler_CF_CList_CF_CList_Pop
  8. UT_DefaultHandler_CF_ProcessGroundCommand
  9. UT_DefaultHandler_CF_TxnStatus_IsError
  10. UT_AltHandler_CF_TraverseAllTransactions_All_Channels_Set_Context
  11. Any_bool
  12. Any_char
  13. AnyBufferOf_uint8_WithSize
  14. Any_0_or_1
  15. Any_uint8_ExceptSetBits
  16. Any_uint8_ExceptUnsetBits
  17. Any_uint16_BetweenExcludeMax
  18. Any_uint16_GreaterThan
  19. Any_uint32_BetweenInclusive
  20. Any_uint32_BetweenExcludeMax
  21. Any_int32_LessThan
  22. Any_int_PositiveExcept
  23. Any_int_ZeroOrPositiveLessThan
  24. Any_int32_ZeroOrPositive
  25. AnyFilenameOfLength
  26. AnyRandomStringOfTextOfLength
  27. Any_CFE_TIME_SysTime_Set
  28. Any_CFE_Status_t_Negative
  29. Any_CFE_Status_t_Except
  30. Any_CFE_Status_t_Negative
  31. Any_condition_code_t

System(s) tested on
RedHat, cFS dev

Additional context
Lcov bundle results using native_std:

Overall coverage rate:
  lines......: 99.2% (30304 of 30537 lines)
  functions..: 99.2% (2428 of 2447 functions)
  branches...: no data found

Lcov bundle results using the old build commands:

Overall coverage rate:
  lines......: 99.2% (30167 of 30396 lines)
  functions..: 99.2% (2417 of 2436 functions)
  branches...: 98.7% (12931 of 13095 branches)

Contributor Info - All information REQUIRED for consideration of pull request
Ariel Walker, MCSG TECH.

@arielswalker arielswalker self-assigned this Jul 30, 2026
@arielswalker
arielswalker force-pushed the fix-506-remove-dead-functions branch from 21992e6 to 03990bc Compare July 30, 2026 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove Dead Functions

1 participant