CUMULUS-4866 Ecarton/metrics swot flag#4465
Merged
Merged
Conversation
…ton/metrics_swot_flag
for more information, see https://pre-commit.ci
bhazuka
approved these changes
May 27, 2026
bhazuka
left a comment
bhazuka
left a comment
Contributor
There was a problem hiding this comment.
We will need to add plans to the migration groups to understand mission != mission in the short term but should be updated to real mission values at a different time.
bhazuka
requested changes
May 29, 2026
bhazuka
left a comment
bhazuka
left a comment
Contributor
There was a problem hiding this comment.
Should probably update packages/db/src/migrations-bootstrap/020_collections.ts with the new column and comment as well.
for more information, see https://pre-commit.ci
bhazuka
approved these changes
May 29, 2026
…ecarton/metrics_swot_flag
for more information, see https://pre-commit.ci
…ecarton/metrics_swot_flag
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Summary of changes
Addresses CUMULUS-4866: Develop amazing new feature
this can either be snuck in as part of 4866, or split off to a new ticket to handle this edge case. the edge case will be a thing in group 2, but not group one, hence the opportunity
Changes
PR Checklist
📝 Note:
For most pull requests, please Squash and merge to maintain a clean and readable commit history.