Skip to content

Fix nasa#231, to_lab app: strcpy() does not check bound. #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
elizabash merged 6 commits into from
Jun 15, 2026
Merged

Fix nasa#231, to_lab app: strcpy() does not check bound. #232

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0abccd7
Fix nasa#231, to_lab app: strcpy() does not check bound.
May 26, 2026
fcc3ef8
Fix nasa#231, to_lab: Fixed format issue.
May 26, 2026
fd9db4a
Fix nasa#231, to_lab app: Changing null terminator manipulation in st…
Jun 9, 2026
c12ea2d
Fix nasa#231, to_lab app: Formatting >:(
Jun 9, 2026
d160ea6
Fix nasa#231, to_lab app: Fixing formatting again
Jun 9, 2026
6a97c47
Fix #231, to_lab app: Tightening code by deleting unecessary actions,…
Jun 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 2 additions & 10 deletions fsw/src/to_lab_app.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,10 +111,6 @@ void TO_LAB_delete_callback(void)
CFE_Status_t TO_LAB_init(void)
{
CFE_Status_t status;
char PipeName[16];
uint16 PipeDepth;
char ToTlmPipeName[16];
uint16 ToTlmPipeDepth;
void *TblPtr;
char VersionString[TO_LAB_CFG_MAX_VERSION_STR_LEN];

Expand All @@ -123,10 +119,6 @@ CFE_Status_t TO_LAB_init(void)

TO_LAB_Global.AllowPassthru = true;
TO_LAB_Global.downlink_on = false;
PipeDepth = TO_LAB_PLATFORM_CMD_PIPE_DEPTH;
strcpy(PipeName, "TO_LAB_CMD_PIPE");
ToTlmPipeDepth = TO_LAB_PLATFORM_TLM_PIPE_DEPTH;
strcpy(ToTlmPipeName, "TO_LAB_TLM_PIPE");

/*
** Register with EVS
Expand Down Expand Up @@ -195,7 +187,7 @@ CFE_Status_t TO_LAB_init(void)
TO_LAB_Global.SubsTblPtr = TblPtr; /* Save returned address */

/* Subscribe to my commands */
status = CFE_SB_CreatePipe(&TO_LAB_Global.Cmd_pipe, PipeDepth, PipeName);
status = CFE_SB_CreatePipe(&TO_LAB_Global.Cmd_pipe, TO_LAB_PLATFORM_CMD_PIPE_DEPTH, "TO_LAB_CMD_PIPE");
if (status != CFE_SUCCESS)
{
CFE_EVS_SendEvent(TO_LAB_CR_PIPE_ERR_EID,
Expand All @@ -212,7 +204,7 @@ CFE_Status_t TO_LAB_init(void)
CFE_SB_Subscribe(CFE_SB_ValueToMsgId(TO_LAB_SEND_HK_MID), TO_LAB_Global.Cmd_pipe);

/* Create TO TLM pipe */
status = CFE_SB_CreatePipe(&TO_LAB_Global.Tlm_pipe, ToTlmPipeDepth, ToTlmPipeName);
status = CFE_SB_CreatePipe(&TO_LAB_Global.Tlm_pipe, TO_LAB_PLATFORM_TLM_PIPE_DEPTH, "TO_LAB_TLM_PIPE");
if (status != CFE_SUCCESS)
{
CFE_EVS_SendEvent(TO_LAB_TLMPIPE_ERR_EID,
Expand Down
Loading